Fix SQL injection via message ID in DbTrackingModule.persist - #567
Merged
uhurusurfa merged 3 commits intoJul 25, 2026
Conversation
The existence-check SELECT concatenated the message ID directly into the SQL, and for inbound messages that value is the partner-controlled Message-ID header. A crafted header could inject SQL (e.g. "x' OR '1'='1" made a new message match an existing row, corrupting tracking) or break the query outright, and persist() swallows the resulting exception so the tracking record was silently lost. Parameterise the existence-check SELECT and escape the message ID in the UPDATE WHERE clause using the existing formatField() helper (the same escaping the SET values already use). Adds a test proving crafted IDs are stored/matched as opaque literals rather than interpreted as SQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existence-check SELECT concatenated the message ID directly into the SQL, and for inbound messages that value is the partner-controlled Message-ID header. A crafted header could inject SQL (e.g. "x' OR '1'='1" made a new message match an existing row, corrupting tracking) or break the query outright, and persist() swallows the resulting exception so the tracking record was silently lost.
Parameterise the existence-check SELECT and escape the message ID in the UPDATE WHERE clause using the existing formatField() helper (the same escaping the SET values already use). Adds a test proving crafted IDs are stored/matched as opaque literals rather than interpreted as SQL.