Skip to content

Update DP_HEADER to include filename in message - #590

Open
JakeHuneau-LSPedia wants to merge 1 commit into
OpenAS2:masterfrom
JakeHuneau-LSPedia:patch-2
Open

Update DP_HEADER to include filename in message#590
JakeHuneau-LSPedia wants to merge 1 commit into
OpenAS2:masterfrom
JakeHuneau-LSPedia:patch-2

Conversation

@JakeHuneau-LSPedia

Copy link
Copy Markdown
Contributor

No description provided.

@uhurusurfa uhurusurfa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you want to add this but it cannot be added because:

  1. The AS2 specification does not require the sender to transmit the file name
  2. It is a breaking change for existing deployments.

The solution is to make all the messages configurable through configuration properties that can be passed in at startup.

Note that the existing messages match the defined AS2 default messages.

The suggested way to support customising the messages for your deployment is to encapsulate all the message strings into a static map with a string identifier as the key and then allow the system to override the strings at startup through added logic in the session configurator.

@JakeHuneau

Copy link
Copy Markdown
Contributor

Understood and fair, feel free to reject and close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants