Update DP_HEADER to include filename in message - #590
Open
JakeHuneau-LSPedia wants to merge 1 commit into
Open
Conversation
uhurusurfa
reviewed
Aug 14, 2026
uhurusurfa
left a comment
Contributor
There was a problem hiding this comment.
I understand why you want to add this but it cannot be added because:
- The AS2 specification does not require the sender to transmit the file name
- It is a breaking change for existing deployments.
The solution is to make all the messages configurable through configuration properties that can be passed in at startup.
Note that the existing messages match the defined AS2 default messages.
The suggested way to support customising the messages for your deployment is to encapsulate all the message strings into a static map with a string identifier as the key and then allow the system to override the strings at startup through added logic in the session configurator.
Contributor
|
Understood and fair, feel free to reject and close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.