Implements DMProc.LocalCount, adds unit test for localvar allocs#2585
Open
tontyGH wants to merge 6 commits into
Open
Implements DMProc.LocalCount, adds unit test for localvar allocs#2585tontyGH wants to merge 6 commits into
tontyGH wants to merge 6 commits into
Conversation
boring-cyborg
Bot
added
Compiler
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalCount is meant to reflect the max amount of variables a proc COULD allocate during its execution, but it used to just naively reflect Proc.LocalNames.Count which doesn't do Any of That.
Fixes #2583
I had to move some stuff around in the compiler to expose the Json object to the unit test, but I triple checked and it should be equivalent function, and consumers can just ignore the version with output.