5.5. random 1k battles elo sampling#58
Open
ErlisLushtaku wants to merge 1 commit into
Open
Conversation
ErlisLushtaku
changed the base branch from
main
to
pr32-split-v3/04-thinking-model-support
ErlisLushtaku
force-pushed
the
pr32-split-v3/04-thinking-model-support
branch
from
673b5fb to
d7f4232
Compare
ErlisLushtaku
force-pushed
the
pr32-split-v3/05.5-elo-sampling
branch
from
cb8ea5b to
524f0f4
Compare
kargibora
reviewed
Jun 8, 2026
kargibora
left a comment
kargibora
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Erlis! I left some comments, everything looks good to me but just some minor issues.
| judge_extra_kwargs["max_model_len"] = args.max_judge_model_len | ||
| if args.chat_template is not None: | ||
| judge_extra_kwargs["chat_template"] = args.chat_template | ||
| judge_extra_kwargs.update(args.engine_kwargs) |
Collaborator
There was a problem hiding this comment.
Why we delete this? Is there a specific reason?
| return slug or "model" | ||
|
|
||
|
|
||
| def _jsonable(value): |
Collaborator
There was a problem hiding this comment.
Take a look at
JudgeArena/judgearena/repro.py
Line 31 in 524f0f4
| "index": int(index) | ||
| if isinstance(index, int | np.integer) | ||
| else str(index), | ||
| "question_id": str(row.get("question_id", "")), |
Collaborator
There was a problem hiding this comment.
I think we can remove the default value, as without question_idwe fail anyways are select_seeded_random_arena_battles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary