VACUUM - Migrate surface current calculation into the VACUUM module - #345
Draft
jhalpern30 wants to merge 12 commits into
Draft
VACUUM - Migrate surface current calculation into the VACUUM module#345jhalpern30 wants to merge 12 commits into
jhalpern30 wants to merge 12 commits into
Conversation
…uum module and making it a flag to compute it
… comments from Claude
…egularization in L calculation and moving to ResponseMatrices.jl
…g advantage of it to remove some lines
…SIONToolkit/GPEC into feature/vacuum-surface-inductance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
The surface inductance calculation is fundamentally a vacuum quantity. It was hacked into GPEC to avoid cross-code changes, but can more simply be integrated into the VACUUM module and passed into the PerturbedEquilibrium module.
This also makes it a boolean if it is computed or not. For the standard stability calculation where only Wv is needed, computing the surface current calculation costs an extra matrix inversion + storage, which can add up especially when making the Wv spline in the edge.