[FROM-ML] asus-armoury: gate PPT writes on active fan curves#52
Open
Ghoul4500 wants to merge 2 commits into
Open
[FROM-ML] asus-armoury: gate PPT writes on active fan curves#52Ghoul4500 wants to merge 2 commits into
Ghoul4500 wants to merge 2 commits into
Conversation
KyleGospo
approved these changes
May 15, 2026
Ghoul4500
force-pushed
the
asus-armoury-gate-ppt
branch
from
5c8183d to
b6fcb17
Compare
KyleGospo
approved these changes
May 15, 2026
…an curve
On models flagged with requires_fan_curve in the DMI power_data table
(28 entries), the BIOS ACPI method SPLX only writes PPT values to the
EC when the fan mode is set to Manual (FANM=4). FANM is set to 4 by
the DEFC method when a custom fan curve is written. Without an active
custom fan curve, the WMI DEVS call returns success but the firmware
silently ignores the PPT value, so userspace observes no effect from
its write.
Gate writes to ASUS_WMI_DEVID_PPT_{PL1_SPL,PL2_SPPT,PL3_FPPT,APU_SPPT,
PLAT_SPPT} on a check of asus_wmi_custom_fan_curve_is_enabled(), and
return -EBUSY with a pr_warn() when no fan curve is active on an
affected model. Export the helper from asus-wmi so asus-armoury can
call it across module boundaries.
Signed-off-by: Ahmed Yaseen <yaseen@ghoul.dev>
…ysfs Expose the per-model requires_fan_curve flag as a read-only sysfs attribute so userspace tools (asusctl, rogcc) can discover whether the system requires an active custom fan curve for PPT changes to take effect, and warn the user before issuing such writes. The attribute appears at: /sys/class/firmware-attributes/asus-armoury/attributes/requires_fan_curve Document the attribute in Documentation/ABI/testing/sysfs-class-firmware-attributes. Signed-off-by: Ahmed Yaseen <yaseen@ghoul.dev>
KyleGospo
force-pushed
the
asus-armoury-gate-ppt
branch
from
b6fcb17 to
1ee713e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lore.kernel.org/platform-driver-x86/20260511061901.907540-1-yaseen@ghoul.dev/T/#m4b34ce78e6234b9a8c9765c3d93d1bd0388689ed