Skip to content

Fix layer resetting when overlay enabled#439

Open
1ec5 wants to merge 3 commits into
stagingfrom
1ec5-layer-reset-1399
Open

Fix layer resetting when overlay enabled#439
1ec5 wants to merge 3 commits into
stagingfrom
1ec5-layer-reset-1399

Conversation

@1ec5

@1ec5 1ec5 commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Cherry-picked openstreetmap#5573 and openstreetmap#5388 from upstream. Fixed the remaining failing JavaScript tests.

Fixes OpenHistoricalMap/issues#1399, fixes OpenHistoricalMap/issues#1180.

@1ec5 1ec5 self-assigned this Jul 14, 2026
@1ec5 1ec5 changed the title Don't remove-readd standard layer when layerParam is not empty in map… Fix layer resetting when overlay enabled Jul 14, 2026
@1ec5
1ec5 force-pushed the 1ec5-layer-reset-1399 branch from aa74a61 to f97aee7 Compare July 18, 2026 18:10
AntonKhorev and others added 2 commits July 18, 2026 11:20
@AntonKhorev @1ec5
Add map.getMapBaseLayer()
b21c9d1
@1ec5
Fixed slippy map tests
8faa359 
These tests assume the default layer is Standard (M), not a vector style like Historical.
@1ec5

1ec5 commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Also cherry-picked 2c84465 from openstreetmap#5388 and fixed the remaining tests in OpenHistoricalMap/issues#1180 by hard-coding the Standard layer, which the tests were expecting as the default. Our default, Historical, doesn’t load because the dev container doesn’t include a local map-styles deployment. (For the same reason, OpenHistoricalMap/issues#1378 still reproduces in the Layers panel.)

@coveralls

coveralls commented Jul 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29657335759

Warning

No base build found for commit 061a1be on staging.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 96.455%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →

Coverage Stats

Coverage Status
Relevant Lines: 7362
Covered Lines: 7101
Line Coverage: 96.45%
Coverage Strength: 896.13 hits per line
💛 - Coveralls

@1ec5
1ec5 requested a review from Rub21 July 18, 2026 19:57
This was referenced Jul 18, 2026
Open
Open
@Rub21 Rub21 mentioned this pull request Jul 20, 2026
Open
@1ec5

1ec5 commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

#443 takes care of the test fixes, so I’ll pare this back to just the fix for layer resetting once that’s in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rub21 Rub21 Rub21 approved these changes

Assignees

@1ec5 1ec5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Layer resets when opening or closing left sidebar with overlay visible Hundreds of ohm-website test failures on staging

4 participants

@1ec5 @coveralls @Rub21 @AntonKhorev