Miller column OSD - #137
Merged
Merged
Conversation
Restore old menu behavior: hide menu items that don't apply to the current receiver mode (WFB vs APFPV). Used internally to gate Camera (size/fps/video mode) and Telemetry (router/osd_fps) options when in direct APFPV WiFi mode. - Add colmenu_mode_t enum (COLMENU_MODE_WFB/APFPV) as bitmask - Add mode_mask field to colmenu_item_t (default 0 = show in all modes) - Skip items in build_page if mode_mask doesn't match current RXMODE - Hide WFB-specific Telemetry items (Router, MSPOSD, OSD FPS) in APFPV - Hide WFB-specific Camera items (Size, Video Mode, FPS) in APFPV Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
henkwiedig
force-pushed
the
miller-column-osd
branch
from
July 8, 2026 17:47
d419e5b to
d2bcabb
Compare
henkwiedig
marked this pull request as ready for review
July 8, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the gsmenu OSD menu from the old lv_menu sidebar model to a descriptor-driven Miller-column menu — every level stays visible side by side, RIGHT/ENTER pushes a column, LEFT/ESC pops. The whole menu tree is now data (colmenu_pages.c), mapped to the same gsmenu.sh get/set protocol as before.
Highlights
Please test thoroughly !!!