Feature/issue 261 export tags -Prune unrelated channel IDs from exported channel tags#288
Open
eddcomeau wants to merge 2 commits intoOpenIntegrationEngine:mainfrom
Open
Conversation
eddcomeau
force-pushed
the
feature/issue-261-export-tags
branch
from
ea12eec to
11557b3
Compare
mgaffigan
approved these changes
Apr 6, 2026
kryskool
approved these changes
Apr 9, 2026
NicoPiel
approved these changes
Apr 10, 2026
Signed-off-by: DESKTOP-9AKG4SL\ecomeau <ecomeau@caredx.com>
Signed-off-by: DESKTOP-9AKG4SL\ecomeau <ecomeau@caredx.com>
eddcomeau
force-pushed
the
feature/issue-261-export-tags
branch
from
11557b3 to
ba793e4
Compare
tonygermano
requested changes
Apr 10, 2026
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
I have a few questions about these changes and the associated issue.
- Where is the import code that looks at this information? Presumably it would need to create the tag in some situations and not create it in others. Can we be certain that this will not cause unwanted behavior in some scenarios?
- The issue suggests emptying the channel list from the exported tag entirely. Is there a reason to keep the current channel Id rather than using an empty Set?
- The issue also identifies a problem with the tags reporting incorrect channel values/counts. Can we confirm why that was the case, and whether this PR resolves that issue or not?
Comment on lines
+1927
to
+1939
| private void addTagsToChannel(Channel channel) { | ||
| List<ChannelTag> channelTags = new ArrayList<ChannelTag>(); | ||
| for (ChannelTag channelTag : getCachedChannelTags()) { | ||
| if (channelTag.getChannelIds().contains(channel.getId())) { | ||
| ChannelTag exportTag = new ChannelTag(channelTag); | ||
| exportTag.setChannelIds(Collections.singleton(channel.getId())); | ||
| channelTags.add(exportTag); | ||
| } | ||
| } | ||
|
|
||
| if (CollectionUtils.isNotEmpty(channelTags)) { | ||
| channel.getExportData().setChannelTags(channelTags); | ||
| } |
Member
There was a problem hiding this comment.
chore: there appears to be a whitespace issue here
Most of this method did not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prunes exported channel tag membership so channel exports only include the exported channel's ID in each tag.
Changes
Verification