docs: define "character" as a Unicode code point in Template Schemas - #188
Merged
mwiebe merged 1 commit intoSep 14, 2026
Merged
Conversation
The length limits in this document are stated in "characters" without defining the term. "Character" can plausibly mean bytes, Unicode code points, or grapheme clusters, and implementations have diverged on it in practice. This defines it once, up front, as a Unicode code point, matching the Expression Language specification's definition of len(). Closes OpenJobDescription#186 Signed-off-by: Yongzhi Wei <276409147+wyongzhi@users.noreply.github.com>
mwiebe
changed the title
mwiebe
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #186
The 2023-09 Template Schemas document states every length limit in "characters" (e.g. JobName "Maximum length: 128 characters") without defining the term. "Character" can plausibly mean bytes, Unicode code points, or grapheme clusters, and implementations have diverged on it in practice: openjd-rs counted UTF-8 bytes under the current wording (fixed in OpenJobDescription/openjd-rs#383 by switching to
.chars().count()), while openjd-model-for-python counts code points, so the same template with a non-ASCII name could be accepted by one implementation and rejected by the other.This adds one sentence to the document preamble defining "character" as a Unicode code point, matching the Expression Language specification's definition of
len()(number of Unicode code points).No limit values change; this only pins down the unit they are measured in.
Closes #186
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.