Skip to content

Added compiler arguments support to JavaCompilerOptions #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venmanyarun merged 2 commits into from
Jun 17, 2026
Merged

Added compiler arguments support to JavaCompilerOptions #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0874f91
Added compilerArgs support to JavaCompilerOptions for passing maven-c…
sajeerzeji Jun 15, 2026
839c990
Added compiler args test
sajeerzeji Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main/java/io/openliberty/tools/common/plugins/util/JavaCompilerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ public class JavaCompilerOptions {
*/
private String annotationProcessors;

/**
* Additional compiler arguments from maven-compiler-plugin's compilerArgs configuration.
*/
private List<String> compilerArgs;

/**
* Get list of options that can be passed to the compiler.
* Options with values are represented as multiple strings in the list
Expand All @@ -74,6 +79,12 @@ public List<String> getOptions() {
addStringOption(options, "-encoding", encoding);
addStringOption(options, "-processorpath", annotationProcessorPath);
addStringOption(options, "-processor", annotationProcessors);

// Add compiler arguments from <compilerArgs> configuration
if (compilerArgs != null && !compilerArgs.isEmpty()) {
options.addAll(compilerArgs);
}

return options;
}

Expand Down Expand Up @@ -140,4 +151,12 @@ public void setAnnotationProcessors(String annotationProcessors) {
this.annotationProcessors = annotationProcessors;
}

public List<String> getCompilerArgs() {
return compilerArgs;
}

public void setCompilerArgs(List<String> compilerArgs) {
this.compilerArgs = compilerArgs;
}

}
15 changes: 15 additions & 0 deletions src/test/java/io/openliberty/tools/common/plugins/util/JavaCompilerOptionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,4 +199,19 @@ public void testAnnotationProcessorsEmpty() throws Exception {
assertTrue(result.contains("-nowarn"));
}

@Test
public void testCompilerArgs() throws Exception {
JavaCompilerOptions jco = new JavaCompilerOptions();
List<String> args = new java.util.ArrayList<>();
args.add("-parameters");
args.add("-Xlint:unchecked");
jco.setCompilerArgs(args);

List<String> result = jco.getOptions();
assertEquals(3, result.size());
assertTrue(result.contains("-nowarn"));
assertTrue(result.contains("-parameters"));
assertTrue(result.contains("-Xlint:unchecked"));
}

}
Loading