Skip to content

[log]: add collection and summary of comparison warnings - #1299

Merged
fso42 merged 1 commit into
masterfrom
improveStandardTestOut
Jun 26, 2026
Merged

[log]: add collection and summary of comparison warnings#1299
fso42 merged 1 commit into
masterfrom
improveStandardTestOut

Conversation

@fso42

@fso42 fso42 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
  • Introduced collectComparisonWarnings to identify and structure flagged differences between simulated, benchmark, and configuration data.

Add a per-test comparison-warnings summary to runStandardTestsCom1DFA.py, surfacing the differences the markdown report flags in red (parameter mismatches excluding Program version, aimec percentage-difference flags, and ppr/pft/pfv plot abs-diff warnings) directly in the run log, without modifying the report itself.

@fso42 fso42 self-assigned this Jun 23, 2026
@fso42 fso42 added the enhancement New feature or request label Jun 23, 2026
@qltysh

qltysh Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread avaframe/log2Report/generateCompareReport.py
Comment thread avaframe/log2Report/generateCompareReport.py
@qltysh

qltysh Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.04%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/log2Report/generateCompareReport.py90.0%245, 260, 262, 275
Total90.0%
🤖 Increase coverage with AI coding...
In the `improveStandardTestOut` branch, add test coverage for this new code:

- `avaframe/log2Report/generateCompareReport.py` -- Lines 245, 260, 262, and 275

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@fso42
fso42 requested review from PaulaSp3 and awirb June 25, 2026 13:16

@PaulaSp3 PaulaSp3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR: #1292, no standardtest fails.

- Introduced `collectComparisonWarnings` to identify and structure flagged differences between simulated, benchmark, and configuration data.

refactor(log2Report): simplify simulation difference handling in comparison report
@fso42
fso42 force-pushed the improveStandardTestOut branch from 6915dce to 11263b0 Compare June 26, 2026 15:51
@fso42 fso42 changed the title feat(log2Report): add collection and summary of comparison warnings [log]: add collection and summary of comparison warnings Jun 26, 2026
@fso42
fso42 merged commit bb4ff5c into master Jun 26, 2026
4 checks passed
@fso42
fso42 deleted the improveStandardTestOut branch June 26, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants