Skip to content

[in3Utils]: cfgUtils handling of nan - #1308

Merged
fso42 merged 1 commit into
masterfrom
JL_UpdateCfgUtils
Jul 6, 2026
Merged

[in3Utils]: cfgUtils handling of nan#1308
fso42 merged 1 commit into
masterfrom
JL_UpdateCfgUtils

Conversation

@JuLa96

@JuLa96 JuLa96 commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

When using the OpenNHM-QGIS-Connector on Windows, in3Utils/cfgUtils.py/convertDF2numerics could not handle nan.

grafik

@JuLa96 JuLa96 added the bugfix label Jul 3, 2026
@JuLa96
JuLa96 requested a review from fso42 July 3, 2026 08:23
@fso42

fso42 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The error message mentions line 951 in cfgUtils (problem with .match) but you changed line 917? Is that on purpose?

@qltysh

qltysh Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/in3Utils/cfgUtils.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

JuLa96
JuLa96 commented Jul 6, 2026
View reviewed changes

@JuLa96 JuLa96 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now. No error message anymore.

@fso42
fso42 force-pushed the JL_UpdateCfgUtils branch from 0d3096b to 4449729 Compare July 6, 2026 09:59
@fso42

fso42 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Standardtests ident apart from know com5

@fso42
fso42 merged commit 75efa16 into master Jul 6, 2026
4 checks passed
@fso42
fso42 deleted the JL_UpdateCfgUtils branch July 6, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fso42 fso42 Awaiting requested review from fso42

Assignees

@fso42 fso42

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JuLa96 @fso42