[com6]: add support for spatialVoellmy friction model - #1312
Merged
Conversation
Contributor
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| black | Style | Incorrect formatting, autoformat by running qlty fmt. |
1 | ❌ |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
fso42
changed the title
spatialVoellmy friction modelspatialVoellmy friction model
awirb
requested changes
Jul 14, 2026
fso42
force-pushed
the
addSpatialToCom6
branch
from
August 12, 2026 12:26
b22c6c9 to
cfe8362
Compare
… model - Introduced a `calibration` parameter to select between `voellmy` or `spatialVoellmy` friction models. - Added error handling for ambiguous or missing inputs. - Updated CLI parser to include a new `--friction_calibration` argument. feat(spatialVoellmyInputs): unify `mu` and `xsi` shapefiles into a single input - Combined separate `mu` and `xsi` shapefiles into a single `*_spatialVoellmy.shp` containing both fields. - Updated error handling to validate the presence of required fields (`mu` and `xsi`) in the single shapefile. docs(spatialVoellmyInputs): update instructions for unified shapefile input - Revised documentation to reflect the use of a single shapefile containing `mu` and `xsi` attributes. feat(spatialVoellmyInputs): add check for existing output files - Added validation to prevent overwriting existing raster output files by checking their existence before writing (`muOut` and `xiOut`).
- Replaced all occurrences of `xsi` with `xi` in function names, variables, comments, and tests for consistency. - Updated configuration files, documentation, and error messages to reflect this change.
fso42
force-pushed
the
addSpatialToCom6
branch
from
August 12, 2026 12:30
cfe8362 to
e2d559a
Compare
Contributor
Author
|
Standard tests ok, apart from known hof |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mu and xsi attributes across spatialVoellmyInputs and runSpatialVoellmyInputs
PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master