Skip to content

[com1]: Update report com1 - #1315

Merged
fso42 merged 1 commit into
masterfrom
updateReportCom1
Jul 15, 2026
Merged

[com1]: Update report com1#1315
fso42 merged 1 commit into
masterfrom
updateReportCom1

Conversation

@awirb

@awirb awirb commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

add info in com1DFA report that projected area and actual area are derived from the release raster and hence are an approximation of the polygon area (deviations are a function of mesh cell size)

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@awirb
awirb requested review from JuLa96 and fso42 July 8, 2026 13:49
@awirb awirb self-assigned this Jul 8, 2026
@awirb awirb added the featureRequest ideas or functions that would be useful label Jul 8, 2026
@awirb awirb changed the title Update report com1 [com1]: Update report com1 Jul 8, 2026
@qltysh

qltysh Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Comment thread avaframe/com1DFA/com1DFA.py Outdated

@fso42 fso42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with MG and CT: Lets add the 'Model area' i.e. area from volume and release height to the log, but not the report yet.

-On ice, as the thickness may also be irregular.

@JuLa96 JuLa96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment from @fso42 above

@awirb
awirb requested a review from fso42 July 15, 2026 09:25
remove decimals from report of areas

fix(tests): correct projected area assertion in `test_com1DFA.py`
@fso42
fso42 force-pushed the updateReportCom1 branch from 4be7e21 to 20d96bc Compare July 15, 2026 11:18
@fso42
fso42 merged commit a0bf150 into master Jul 15, 2026
7 of 9 checks passed
@fso42
fso42 deleted the updateReportCom1 branch July 15, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureRequest ideas or functions that would be useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants