Skip to content

fix(com4FlowPy): defining default as fallback - #1326

Merged
fso42 merged 1 commit into
OpenNHM:masterfrom
MunsMan:HM_com4_pra_variable
Aug 17, 2026
Merged

fix(com4FlowPy): defining default as fallback#1326
fso42 merged 1 commit into
OpenNHM:masterfrom
MunsMan:HM_com4_pra_variable

Conversation

@MunsMan

@MunsMan MunsMan commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

I discovered yesterday an edge case in the PRA configuration via input files.
It missed to reapply the default value, if the input files provides an invalid value. In such a case we where reusing the previous value.

Visually, this impacted the results:

before:
before_zdelta

after:
after_zdelta

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@fso42
fso42 requested review from PaulaSp3 and ahuber-bfw August 14, 2026 09:34
@fso42 fso42 added the confirmed Something isn't working label Aug 14, 2026
@fso42

fso42 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Thanks, I'll wait for feedback from @PaulaSp3 or @ahuber-bfw

Sidenote: I you want I can invite you to the OpenNHM Team and you can work directly on the repo... Just let me know

@ahuber-bfw ahuber-bfw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • immediate fix for the re-initialisation of parameters in case of missing or invalid values in the input rasters ✓
  • as a follow up I would suggest also adapting com4FlowPy.checkInputParameterValues() to check input parameters before the model is run (#1327)

@PaulaSp3 PaulaSp3 assigned fso42 and unassigned PaulaSp3 Aug 17, 2026
@fso42
fso42 merged commit 519952f into OpenNHM:master Aug 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants