[com8/9; com1]: ensure forest effects handle remeshing correctly - #1329
Merged
Conversation
Contributor
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Components (1)
Modified Files with Diff Coverage (3)
🛟 Help
|
…im types correctly - Updated logic in `MoTUtils.py` to disable forest effects for non-res simulations.
fso42
force-pushed
the
cleanMOTResRemesh
branch
from
August 24, 2026 08:41
b5c45e8 to
b308db3
Compare
awirb
approved these changes
Aug 24, 2026
…y in simulations - Updated `MoTUtils` to enable forest effects when remeshed forest density and tree diameter files are found. - Adjusted `com8MoTPSA` and `com1DFA` to handle forest effects with "auto" setting only. - Removed outdated logic for non-auto forest effect configurations. - Updated tests to verify correct forest density file usage and handling of "auto" mode. test(com8MoTPSA): add unit tests for postprocess layer renaming and entrainment sim types test(com1DFA, com8MoTPSA): add unit tests for forest effects in simulations - Added tests for `prepareVarSimDict` in `com1DFA` to verify forest block remeshing and path settings for bhd/res. - Introduced preprocess tests in `com8MoTPSA` to validate forest effects with "auto" and non-auto settings. fix(com1DFA): remove redundant file existence checks for `entFile` and `resFile` in config settings
fso42
force-pushed
the
cleanMOTResRemesh
branch
from
August 25, 2026 12:43
0a20993 to
10a3f52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoTUtils.pyto disable forest effects for non-res simulations.PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master