NMS-20100: PrimeVue Notifications page with a General configuration tab (base) - #8693
Conversation
aca83a6 to
145fca4
Compare
cgorantla
left a comment
There was a problem hiding this comment.
@joseanesONMS This is not running any tests as it is coming from fork, can we directly create branch on this repo and open PR ?
|
@cgorantla Happy to — but I don't currently have write access to OpenNMS/opennms (push returns 403 for joseanesONMS), so I can't create in-repo branches myself. If you can grant me write access I'll recreate both this PR and #8692 from in-repo branches right away; alternatively a maintainer with access could push the branch (maintainer edits are allowed on this PR). In the meantime I'm adding unit/component tests to the PR. |
|
Tests added in 0640aad: |
3fd2a51 to
5858250
Compare
|
Rebased onto current develop: the UI seam layer work (NMS-20029/NMS-20081) moved ConfirmationDialog and OnmsIconButton into |
Rewrites the Notifications page (notice queries, outstanding/acknowledged notice lists with CSV export and printing, collapsible explanations) as a PrimeVue page backed by REST, and adds a Configure Notifications dialog holding a General tab with the system-wide notification on/off switch. Adds the admin-only /rest/notification-config endpoints for the notifd status and the read side of destination paths (the base API surface for the dependent tab PRs), backed by the same file-backed factories the legacy wizards use — the XML files stay the system of record. Browser delivery of notices for /ui pages ships here as well. The Event Notifications, Destination Paths and Path Outages tabs follow in dependent PRs.
5858250 to
7e292d0
Compare
7e292d0 to
b6c2512
Compare
|
Replaced by #8709 (in-repo branch on the jira/NMS-20100 epic feature branch, so CI runs). |
Rewrites the Notifications page as PrimeVue backed by REST, split from the original single PR for ease of review. This base PR carries the page itself and a Configure Notifications dialog with only the General tab; the Event Notifications, Destination Paths and Path Outages tabs follow in dependent PRs.
Dependent PRs: Event Notifications tab, Destination Paths tab, Path Outages tab (each contains this PR's commit until it merges).