Skip to content

NMS-20100: PrimeVue Notifications page with a General configuration tab (base) - #8693

Closed
joseanesONMS wants to merge 1 commit into
OpenNMS:developfrom
joseanesONMS:jira/NMS-20100-notifications-admin-primevue
Closed

NMS-20100: PrimeVue Notifications page with a General configuration tab (base)#8693
joseanesONMS wants to merge 1 commit into
OpenNMS:developfrom
joseanesONMS:jira/NMS-20100-notifications-admin-primevue

Conversation

@joseanesONMS

@joseanesONMS joseanesONMS commented Jul 29, 2026

Copy link
Copy Markdown

Rewrites the Notifications page as PrimeVue backed by REST, split from the original single PR for ease of review. This base PR carries the page itself and a Configure Notifications dialog with only the General tab; the Event Notifications, Destination Paths and Path Outages tabs follow in dependent PRs.

  • Notifications page: notice queries (per-user, outstanding, acknowledged), the outstanding-notices list with acknowledge, CSV export and printing, and collapsible explanations.
  • Configure Notifications dialog (gear icon) with the General tab: the system-wide notification on/off switch.
  • Adds admin-only /rest/notification-config endpoints for the notifd status plus the read side of destination paths (shared by the dependent tab PRs), delegating to the same file-backed factories the legacy wizards use — the XML files stay the system of record.
  • Browser delivery of notices for /ui pages.
  • The admin menu entry points at the new page.

Dependent PRs: Event Notifications tab, Destination Paths tab, Path Outages tab (each contains this PR's commit until it merges).

@joseanesONMS
joseanesONMS force-pushed the jira/NMS-20100-notifications-admin-primevue branch from aca83a6 to 145fca4 Compare July 29, 2026 19:05

@cgorantla cgorantla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseanesONMS This is not running any tests as it is coming from fork, can we directly create branch on this repo and open PR ?

@joseanesONMS

Copy link
Copy Markdown
Author

@cgorantla Happy to — but I don't currently have write access to OpenNMS/opennms (push returns 403 for joseanesONMS), so I can't create in-repo branches myself. If you can grant me write access I'll recreate both this PR and #8692 from in-repo branches right away; alternatively a maintainer with access could push the branch (maintainer edits are allowed on this PR). In the meantime I'm adding unit/component tests to the PR.

@joseanesONMS

Copy link
Copy Markdown
Author

Tests added in 0640aad: NotificationConfigRestServiceIT (full REST surface: notifd status, event notification / destination path lifecycles, path outage apply/clear/preview, admin guard — 8 tests, follows the ScheduledOutagesRestServiceIT pattern with seeded config files and a mocked FilterDao) plus Vitest suites for the two new Pinia stores (25 tests). All green locally: mvn -pl opennms-webapp-rest verify -Dit.test=NotificationConfigRestServiceIT -DskipITs=false and cd ui && vitest run tests/stores. Still happy to move this to an in-repo branch as soon as I have write access.

@joseanesONMS
joseanesONMS force-pushed the jira/NMS-20100-notifications-admin-primevue branch from 3fd2a51 to 5858250 Compare July 30, 2026 13:35
@joseanesONMS

Copy link
Copy Markdown
Author

Rebased onto current develop: the UI seam layer work (NMS-20029/NMS-20081) moved ConfirmationDialog and OnmsIconButton into @opennms/onms-ui, which this PR's components imported from their old location. Adapted in the final commit (same APIs, new imports); everything re-verified on the rebased branch — 15 integration tests, 26 store tests, full UI typecheck/build.

Rewrites the Notifications page (notice queries, outstanding/acknowledged
notice lists with CSV export and printing, collapsible explanations) as a
PrimeVue page backed by REST, and adds a Configure Notifications dialog
holding a General tab with the system-wide notification on/off switch.

Adds the admin-only /rest/notification-config endpoints for the notifd
status and the read side of destination paths (the base API surface for the
dependent tab PRs), backed by the same file-backed factories the legacy
wizards use — the XML files stay the system of record. Browser delivery of
notices for /ui pages ships here as well. The Event Notifications,
Destination Paths and Path Outages tabs follow in dependent PRs.
@joseanesONMS
joseanesONMS force-pushed the jira/NMS-20100-notifications-admin-primevue branch from 5858250 to 7e292d0 Compare July 30, 2026 20:05
@joseanesONMS joseanesONMS changed the title NMS-20100: PrimeVue Notifications page with REST-backed configuration NMS-20100: PrimeVue Notifications page with a General configuration tab (base) Jul 30, 2026
@joseanesONMS
joseanesONMS force-pushed the jira/NMS-20100-notifications-admin-primevue branch from 7e292d0 to b6c2512 Compare July 30, 2026 20:26
@joseanesONMS

Copy link
Copy Markdown
Author

Replaced by #8709 (in-repo branch on the jira/NMS-20100 epic feature branch, so CI runs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants