NMS-20120: Path Outages tab - #8712
Open
joseanesONMS wants to merge 3 commits into
Open
Conversation
Author
|
@marshallmassengill review requested — stacks on #8709 (only the top commit is new here). |
joseanesONMS
force-pushed
the
jira/NMS-20120-path-outages
branch
from
July 30, 2026 21:59
15d739a to
e4746e4
Compare
joseanesONMS
force-pushed
the
jira/NMS-20120-path-outages
branch
3 times, most recently
from
August 1, 2026 02:24
0439cf2 to
89e6936
Compare
marshallmassengill
requested changes
Aug 3, 2026
marshallmassengill
left a comment
marshallmassengill
left a comment
Contributor
There was a problem hiding this comment.
Minor stuff on this one... it's actually shockingly self-contained.
- Tab opens pre-armed to clear every node. PathOutagesTab.vue:228-229. rule defaults to IPADDR IPLIKE ..., blank criticalIp makes the button "Clear Critical Path". Start rule empty (as was the case with legacy behavior).
- Confirmation count is nodes matching the rule, not nodes with a path. PathOutagesTab.vue:250. Says 4823 when 3 rows delete. Count existing paths in the preview.
- Tab loader returns literal true. ConfigureNotificationsDialog.vue:95. Failed GET latches loaded, never retries. Return null from getPathOutages on error.
- Only raw JDBC in the REST module; PathOutageDao has full CRUD plus getAllCriticalPaths().
- isBlank dead again. NotificationConfigRestService.java:230.
joseanesONMS
force-pushed
the
jira/NMS-20120-path-outages
branch
2 times, most recently
from
August 3, 2026 17:13
24c0485 to
b28131f
Compare
Adds the Path Outages tab: the list of configured critical paths and the apply/clear flow driven by a filter rule with a node-count preview, in place of the legacy notification wizard pages. Storage is and stays the pathoutage table; the endpoints mirror the legacy NotificationWizardServlet semantics, including clearing the path when the critical IP is blank. Depends on the Notifications page base PR.
The node-filter rule now starts empty instead of IPADDR IPLIKE *.*.*.*, so the tab no longer opens pre-armed to clear the critical path for every node. The clear confirmation counts only the nodes that currently have a critical path and match the rule, not every node the rule selects, so it no longer claims thousands when a handful of rows will change. The path-outages tab loader now propagates a real success flag — getPathOutages returns null on error and the store reports false — so a failed load retries instead of latching the tab empty. Also drops the unused isBlank helper from NotificationConfigRestService.
Migrate the Path Outages tab onto the Onms-* seam wrappers (table, chip, buttons, inputs, select) so the page passes the no-direct-primevue lint rule; iftalabel stays on PrimeVue as it has no wrapper. Markup and behaviour are unchanged.
joseanesONMS
force-pushed
the
jira/NMS-20120-path-outages
branch
from
August 3, 2026 21:58
b28131f to
2228c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NMS-20120 (NMS-20100 epic): adds the Path Outages tab to the Configure Notifications dialog. Stacked on #8709, so this PR shows only its own commit.