NMS-20124: point the notification bell at the new Notifications page - #8719
Open
joseanesONMS wants to merge 3 commits into
Open
NMS-20124: point the notification bell at the new Notifications page#8719joseanesONMS wants to merge 3 commits into
joseanesONMS wants to merge 3 commits into
Conversation
Author
|
@marshallmassengill review requested — stacks on #8709 (only the top commit is new here). |
The bell dropdown links now land on the Vue Notifications page with the matching preset applied, and the status row opens the page that hosts the configuration dialog. The dropdown says notifications instead of notices, matching the page. The team row gets a real filter: a new excludeNotifiedUser parameter on the v1 notifications list applies the same criteria the summary endpoint uses for its team count (notified users other than you, or nobody), and the page exposes it as a fourth query preset, so the bell's 'N of M assigned to anyone but you' lands on exactly those N.
joseanesONMS
force-pushed
the
jira/NMS-20124-bell-notifications
branch
from
July 31, 2026 19:33
3cca45a to
00941d5
Compare
…sh, dark mode, and query correctness
Clicking a specific notice in the bell now opens the new Notifications
page filtered to the user's outstanding notices instead of the legacy
notification/detail.jsp. Re-apply the preset on route-query change so a
bell click while already on the page refreshes the list (the component
is not remounted on a hash-query change).
Fix the teamOutstanding ("assigned to anyone but you") query: the
usersNotified LEFT_JOIN with or(ne,isNull) duplicated notices and
inflated the count, so mark the criteria distinct; and always consume a
blank excludeNotifiedUser param so it is not mis-parsed as an entity
property (was a 500). Add a dark-mode text fix for the notifications
page and its dialogs, keyed off the reliable html.open-dark class since
the PrimeVue dark tokens do not reach the custom/teleported text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NMS-20124 (NMS-20100 epic): the top-bar bell dropdown now lands on the new Notifications page instead of the legacy notification/browse JSP. Stacked on #8709, so this PR shows only its own commit.
excludeNotifiedUserparameter on the v1 notifications list — the same criteria the summary endpoint uses for that count, so the list shows exactly the N the bell promises.