NMS-20105: Close the trouble ticket when the alarm clears - #8720
Open
cgorantla wants to merge 2 commits into
Open
NMS-20105: Close the trouble ticket when the alarm clears#8720cgorantla wants to merge 2 commits into
cgorantla wants to merge 2 commits into
Conversation
The notification command now sends a close for a cleared alarm that still has an active ticket, instead of creating another one, so the resolution delivery completes the workflow. Renames the example command to troubleTicket.
marshallmassengill
requested changes
Aug 3, 2026
Contributor
There was a problem hiding this comment.
- Close races alarmd, fails silently. sendResolvedNotificationsToUser queues at now. initial-delay applies only to the original notice. If notifd's SELECT a.severity beats alarmd's clear commit, isCleared() is false, control falls to the create branch, hasActiveTicket() returns 0, and nothing happens. answeredby LIKE '%auto-acknowledged%' is written synchronously before the re-run (NotificationManager.java:713-729).
- Manually acked notice never closes its ticket (not sure this matters but putting the observation in here)
- CLOSE_PENDING isn't in INACTIVE_TICKET_STATES, so an in-flight UI close gets a duplicate close; ditto every escalation stage / group member. Create side has a guard but close side doesn't.
- isTicketCreationPending can't fire for this strategy's own creates. createTicketForAlarm sets only OPEN/CREATE_FAILED
- Tests leave m_severity == 0, not a valid OnmsSeverity id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notification command now sends a close for a cleared alarm that still has an active ticket, instead of creating another one, so the resolution delivery completes the workflow. Renames the example command to troubleTicket.
External References