Skip to content

Coordinate rank-local planning failures before collective admission - #907

Merged
bradhilton merged 1 commit into
mainfrom
schulman/art906-planning-status
Sep 16, 2026
Merged

bradhilton merged 1 commit into
mainfrom
schulman/art906-planning-status

Conversation

@bradhilton

@bradhilton bradhilton commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

A rank-local estimator, materializer, or memory-pricing error could leave another rank waiting in the next collective. Exchange each pure planning phase's success before proceeding, so peers fail promptly and the originating rank keeps its original exception and chain. Legal unavailable estimates still take the existing fallback path; empty and unequal local groups use the same collective sequence.

Fixes #906. Runtime changes stay within art.trainer_rank; public APIs, planner arithmetic, checkpoint ordering, and art.megatron are unchanged. This does not adopt #900. Memory-estimation work remains open in #848 and #870.

Validation: 153 distinct focused repository tests passed, including a two-process CPU/Gloo regression covering six failure/empty/unequal/unavailable cases and eight exception-chain controls. Changed-file Ruff, formatting, type checks, and diff checks pass. The exact patch also composes without conflict on main e9c68ccc, with identical changed-file blobs. Hosted CI is pending.

The simple scheduler path adds four status reductions; repeated width/layout checks can add more. Native NCCL and latency are not qualified. Checkpoint-loading errors, later CUDA-counter failures, and communicator failures remain outside this narrow fix. The original failed reproduction and its evidence are preserved in #906.

@bradhilton
bradhilton deployed to trainer-rank-gpu-validation September 16, 2026 03:44 — with GitHub Actions Active

@bradhilton bradhilton left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review text removed on 2026-09-17; the consolidated review record is in the summary comment on this PR.

@bradhilton bradhilton left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review text removed on 2026-09-17; the consolidated review record is in the summary comment on this PR.

@bradhilton

Copy link
Copy Markdown
Collaborator Author

Consolidated review record (automated agent review traffic removed 2026-09-17)

Change. Exchanges each planning phase's success between ranks in art.trainer_rank so a rank-local estimator, materializer, or memory-pricing error fails peers promptly rather than stranding them in the next collective; the originating rank keeps its original exception and chain. Fixes #906.

Review. McCarthy and Minsky reviewed head 5ea4548; both returned CLEAR on source correctness within scope, no changes requested. Minsky ran the new tests (44 passed, including the two-process Gloo case) plus 175 backend-stage tests with and without Megatron, and confirmed the new tests fail on the base runtime; McCarthy hash-verified the retained 153-case evidence and ran 42 control-flow checks. Both reproduced the composition onto main; CI was still running when the reviews posted.

Deferred / follow-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TrainerRank: rank-local planning errors leave peers waiting in a collective

1 participant