Centralize tokenizer defaults and preserve sampled inference history - #909
Merged
Merged
Conversation
bradhilton
marked this pull request as ready for review
September 16, 2026 15:51
bradhilton
commented
Sep 16, 2026
bradhilton
commented
Sep 16, 2026
Collaborator
Author
|
Consolidated review record (automated agent review traffic removed 2026-09-17) Change. Centralizes default tokenizer loading in Review. McCarthy and Minsky reviewed at Findings addressed during review.
Deferred / follow-ups.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Templates can trim sampled reasoning, remove old analysis, or change turn terminators when a conversation is rendered again. That breaks token-prefix continuity and forces training code to split histories even when the caller only appends a turn.
This change centralizes default tokenizer loading in
art.get_tokenizer(base_model, revision=..., **kwargs)and moves Caladan’s prefix-cache implementation into ART. Shared inference helpers preserve template history and native sampled prefixes across vLLM, SGLang, and the Tinker adapters. Ordinary requests use the server-side cache without client IDs or extra headers. Explicit history-removal options remain supported; captured training IDs and log probabilities remain the actual served evidence.The lightweight
art_inferencepackage has no import-time training dependencies. The standalone vLLM runtime bundles the same source files, including in its sdist. Caladan retains distributed cache transport and transaction handling; its integration is in OpenPipe/caladan#419.Validation:
eac8d9acd: 782 training integration tests and 1,504 unit tests passed; 68 unit tests skipped.chat_template=Noneselects the native default encoder. All 69 focused regressions pass; the reviewer’s native vLLM budget and Hugging Face default-template probes also pass.No live GPU inference or deployment was performed. Cache misses, evictions, ambiguous tokenizations, explicit history removal, and incomplete turns can still result in multiple training histories; this change does not rewrite training evidence to conceal those cases.