Clean up cancelled GPU image builders - #923
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelled image workflows can leave their remote BuildKit processes running and publishing to
latest. During the main image failure investigation, run 35169703834 was already cancelled while its builder was still exporting; a second cancelled run also left its completed builder behind.Give each CI builder a name derived from the workflow run and attempt, and delete that exact pod in an
always()step. This provides cleanup even when cancellation kills the shell before the build script's EXIT trap completes.Also wait for deletion before reusing a prewarm tag-check pod's name. Previously the script could apply to a terminating pod and then spend its ten-minute readiness timeout waiting for that pod to become ready. The replacement uses the existing bounded deletion helper.
Validation: parsed the workflow YAML, checked every shell step and the build script with
bash -n, ran the image build-context test, and executed the cleanup step against a recording kubectl stub to verify the context, namespace, exact pod name, and nonblocking deletion. The two confirmed orphaned builders were stopped during the investigation.