Francofil brand update - #298
Open
oncleben31 wants to merge 15 commits into
Open
Conversation
- Add comprehensive Francofil material definitions - Add material packages for all Francofil products - Add material container configurations (1kg, 500g, 5-10kg spools) Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
- Remove francofil-asa-rouge.yaml (duplicate of asa-red) - Remove francofil-asa-blanc.yaml (duplicate of asa-white) - Remove francofil-asa-gris.yaml (duplicate of asa-grey) - Keep English versions: asa-black, asa-red, asa-white, asa-grey, asa-virgin, asa-rose-fme - URLs remain in French as they are the only valid ones on the manufacturer's website Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
- Rename francofil-detectable-petg-m-xr.yaml -> francofil-petg-detectable-m-xr.yaml - Rename francofil-green-iridescent-glitter-pla.yaml -> francofil-pla-green-iridescent-glitter.yaml - Rename francofil-peacock-blue-pla.yaml -> francofil-pla-peacock-blue.yaml - Update all corresponding material-packages filenames - Update all slugs to match new filenames - Fix peacock-blue slug (was missing 'e' in 'peacock') - Maintain UUID consistency across all changes Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
- Rename francofil-translucent-blue-pla.yaml -> francofil-pla-translucent-blue.yaml - Rename francofil-translucent-orange-pla.yaml -> francofil-pla-translucent-orange.yaml - Rename francofil-turquoise-blue-pla.yaml -> francofil-pla-turquoise-blue.yaml - Rename francofil-virgin-petg-esd.yaml -> francofil-petg-virgin-esd.yaml - Rename francofil-white-petg-ptfe.yaml -> francofil-petg-white-ptfe.yaml - Update material names to start with type (PLA/PETG): - Translucent Blue PLA -> PLA Translucent Blue - Translucent Orange PLA -> PLA Translucent Orange - Turquoise Blue PLA -> PLA Turquoise Blue - Virgin PETG ESD -> PETG Virgin ESD - White PETG PTFE -> PETG White PTFE - PLA Translucent Green (already correct filename) - PLA Yellow Translucent (already correct filename) - Update all corresponding material-packages filenames and slugs - Maintain UUID consistency (based on brand UUID + material name per spec) Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
- Remove francofil-pla-caf-coproduced.yaml (duplicate of cafe-coproduced) - Remove francofil-pla-bois-co-produced.yaml (duplicate of wood-co-product) - Remove francofil-pla-bleu-pastel-le-glacier.yaml (duplicate of pastel-blue-le-glacier) - Update material names to English: - PLA Café - Coproduced -> PLA Coffee - Co-produced - PLA Bois - Co-produced -> PLA Wood - Co-product - PLA Bleu Pastel - Le Glacier -> PLA Pastel Blue - Le Glacier - PLA count now matches manufacturer website: 63 PLA materials - Total materials: 99 (was 102) Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
- Added min/max print and bed temperatures for 8 materials with reliable data - PETG Detectable M-XR: 225-250°C / 65-75°C - PETG ESD Red: 270-290°C / 80-85°C - PETG Virgin ESD: 270-290°C / 80-85°C - PETG White PTFE: 230-245°C / 60-90°C - PETG Carbon: 225-255°C / 60-90°C - ABS Blanc/Noir/Vierge: 250-270°C / 90-110°C - Density values added where available - Only used data from well-formatted product pages - See Issue #27 for table formatting problems on manufacturer site - See Issue #28 for list of materials without extracted properties Closes #26 Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
…sing) - Extracted min/max print and bed temperatures from 97 Francofil materials - Used direct HTML parsing to read <th>/<td> table structure - PLA (63 materials): 200-230°C / 30-70°C - ASA (6 materials): 240-260°C / 90-110°C - PETG (11 materials): 220-260°C / 70-90°C - ABS (6 materials): 250-270°C / 90-110°C - TPU 95A (5 materials): 210-240°C - TPU 98A (4 materials): 210-240°C - TPE 88A (2 materials): 210-240°C - Special materials (ESD, Detectable, PTFE, Carbon) keep their specific values - All 99 Francofil materials now have printing properties Special cases: - PETG Detectable M-XR: 225-250°C / 65-75°C - PETG ESD (Red & Virgin): 270-290°C / 80-85°C - PETG White PTFE: 230-245°C / 60-90°C - PETG Carbon: 225-255°C / 60-90°C - ABS Rose FME: 250-270°C / 90-110°C (corrected from 190-110°C) - ASA Rose FME: 240-270°C / 90-110°C Closes #26 Closes #28 Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
…et-ral-4009) Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
Corrected UUIDs to use the proper derivation method (UUIDv5 based on brand UUID + material name) instead of SHA256-based hashing. Affected materials: - francofil-pla-turquoise-blue - francofil-asa-rose-fme-foreign-material-exclusion-pmuc-certified - francofil-pla-translucent-orange - francofil-petg-white-ptfe - francofil-pla-cafe-coproduced - francofil-pla-translucent-blue - francofil-petg-virgin-esd Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
oncleben31
marked this pull request as ready for review
August 26, 2026 11:45
Co-authored-by: oncleben31 <oncleben31@users.noreply.github.com>
ondratu
requested changes
Aug 31, 2026
ondratu
left a comment
ondratu
left a comment
Contributor
There was a problem hiding this comment.
I noticed that you removed some materials. If a material is discontinued, it should still stay in the database for encyclopedic reasons, and of course, in case some 3D printer owners still have it.
| @@ -0,0 +1,10 @@ | |||
| slug: francofil-abs-black-1000-spool | |||
Contributor
There was a problem hiding this comment.
Why do you use spool sutfix in material-package?
Contributor
Author
There was a problem hiding this comment.
I have the feeling this is a convention for material package. Prusament brand use it. And if the Francofil will use refill in the future it will be easy to differentiate 1K with spool and 1K without.
@ondratu is there another convention ?
| @@ -0,0 +1,10 @@ | |||
| slug: francofil-abs-rose-fme-foreign-material-exclusion-pmuc-certified-1000-spool | |||
Contributor
There was a problem hiding this comment.
his is derived from the material name, so please see my comment above.
Contributor
Author
There was a problem hiding this comment.
Waiting your answer on my feedback above.
| @@ -10,4 +10,5 @@ url: https://francofil.fr/en/product/tpu-98a-bleu/ | |||
| primary_color: | |||
| color_rgba: '#0353baff' | |||
| properties: | |||
| hardness_shore_a: 98 | |||
| min_print_temperature: 210 | |||
Contributor
There was a problem hiding this comment.
Why did you remove the hardness_shore_a attribute?
| @@ -10,4 +10,5 @@ url: https://francofil.fr/en/product/tpu-98a-gris/ | |||
| primary_color: | |||
| color_rgba: '#6a6c6eff' | |||
| properties: | |||
| hardness_shore_a: 98 | |||
| min_print_temperature: 210 | |||
Contributor
There was a problem hiding this comment.
Why did you remove the hardness_shore_a attribute?
| @@ -10,4 +10,5 @@ url: https://francofil.fr/en/product/tpu-98a-rouge/ | |||
| primary_color: | |||
| color_rgba: '#ec0000ff' | |||
| properties: | |||
| hardness_shore_a: 98 | |||
| min_print_temperature: 210 | |||
Contributor
There was a problem hiding this comment.
Why did you remove the hardness_shore_a attribute?
| @@ -13,4 +13,5 @@ tags: | |||
| - without_pigments | |||
| - transparent | |||
| properties: | |||
| hardness_shore_a: 98 | |||
| min_print_temperature: 210 | |||
Contributor
There was a problem hiding this comment.
Why did you remove the hardness_shore_a attribute?
| @@ -10,4 +10,5 @@ url: https://francofil.fr/en/product/tpu-98a-blanc/ | |||
| primary_color: | |||
| color_rgba: '#f5f5f5ff' | |||
| properties: | |||
| hardness_shore_a: 98 | |||
| min_print_temperature: 210 | |||
Contributor
There was a problem hiding this comment.
Why did you remove the hardness_shore_a attribute?
- Rename material container from francofil-spool-5-10kg to francofil-spool-10kg - Update all 129 material-packages to reference the new container - Add Naming Conventions section to CONTRIBUTING.md - Add .cache/ to .gitignore Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
- Rename 4 materials (abs, asa, petg, pla) from foreign-material-exclusion to pmuc-certified - Rename 24 material-packages to match new material slugs - Keep name property unchanged as requested Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now the database should be consistent with the public catalog as much as possible
Note: this work has been co-authored with Mistral/Vibe AI code assistant. Instructed and reviewed by me.