Update OpenPrintTag Architecture schema version - #299
Open
ondratu wants to merge 3 commits into
Open
Conversation
ondratu
marked this pull request as draft
August 27, 2026 11:19
Wire the wash-media entity into the JSON schema validator (schema + brand foreign key check) and add a test proving invalid wash-media data is actually rejected. Add the generic water wash medium using the g/cm³ and cm²/g units from the updated architecture schema.
ondratu
marked this pull request as ready for review
August 28, 2026 13:33
test_validate_wash_media.py needs the real fetched schema to validate against; the test target only depended on setup, so a fresh CI checkout had no ./openprinttag/schema and the test job failed on PR #299 while local runs (with schemas already fetched) passed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.