pwgtoraster: reject overflowing raster buffers - #210
Merged
tillkamppeter merged 2 commits intoAug 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size_tfor averaging and planar row offsets, and handle all three allocation failures before raster decodingFixes #192.
Fixes #193.
Fixes #194.
Testing
Built the library with AddressSanitizer and UndefinedBehaviorSanitizer, then ran each issue's exact public Raster fixture through
cfFilterPWGToRaster:6a07436a...): rejects the 447,439-byte row before 9,600x expansioneb3985c5...): rejects the 65,536 x 65,536 planar page before allocationad3a0b92...): rejects the 512 x 8,388,609 averaging buffer before allocationAll three complete without sanitizer diagnostics. The normal sanitizer control set also passes 3/3 (
testdither,testpdf1, andcupsfilters/testfilters.sh), andgit diff --checkpasses.