libcupsfilters.pc: Add pdfio as public Requires dependency - #219
Open
princemittalr wants to merge 1 commit into
Open
libcupsfilters.pc: Add pdfio as public Requires dependency#219princemittalr wants to merge 1 commit into
princemittalr wants to merge 1 commit into
Conversation
pdf.h (a public installed header) includes <pdfio.h> directly, which means downstream packages (e.g. libppd) that include pdf.h need pdfio headers and types at compile time. Moving pdfio from Libs.private to Requires ensures pkg-config propagates this dependency correctly. Fixes: OpenPrinting#213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #213
pdf.h is a public installed header that includes <pdfio.h> directly:
This means downstream packages (e.g. libppd) that include pdf.h need
pdfio headers and types at compile time. However, pdfio was only listed
in Libs.private, which pkg-config does not propagate to consumers.
Fix: add pdfio to Requires and remove it from Libs.private to avoid
double-linking.