Printer compatibility recommendations for the Foomatic directory (GSoC 2026)

.github/workflows/build.yml

@@ -76,8 +76,13 @@ jobs:
       - name: Run linter
         run: ${{ steps.pm.outputs.runner }} lint
 
+      - name: Run unit tests
+        run: ${{ steps.pm.outputs.runner }} test
+
       - name: Build Next.js
         run: ${{ steps.pm.outputs.runner }} build
+        env:
+          FOOMATIC_SKIP_SIMILARITY: "1"
 
       - name: Verify URL conventions
         run: ${{ steps.pm.outputs.runner }} verify:urls

.github/workflows/deploy.yml

@@ -4,6 +4,10 @@ on:
   push:
     branches: [master]
 
+  # Weekly rebuild so recommendations pick up upstream foomatic-db changes.
+  schedule:
+    - cron: "0 2 * * 1"
+
   workflow_dispatch:
 
 permissions:

app/foomatic/printers/page.tsx

@@ -261,18 +261,17 @@ export default function HomePage() {
 
     if (selectedColorCapability !== "all") {
       result = result.filter((printer) => {
-        const type = printer.type?.toLowerCase() || ""
-        const model = typeof printer.model === "string" ? printer.model.toLowerCase() : ""
+        const color = printer.color
 
         if (selectedColorCapability === "color") {
-          return type.includes("color") || model.includes("color")
+          return color === true
         }
 
         if (selectedColorCapability === "monochrome") {
-          return type.includes("mono") || type.includes("dot-matrix") || model.includes("mono")
+          return color === false
         }
 
-        return true
+        return color === "unknown" || color === undefined
       })
     }
 

components/foomatic/DriverPageClient.tsx

@@ -20,6 +20,7 @@ import {
 import { Button } from "@/components/ui/button"
 import { withBasePath } from "@/lib/foomatic/base-path"
 import { driverHref, printerHref } from "@/lib/foomatic/routes"
+import { sanitizeFoomaticHtml } from "@/lib/foomatic/sanitize"
 import type { DriverRecord } from "@/lib/foomatic/types"
 
 interface DriverPageClientProps {
@@ -83,7 +84,7 @@ export default function DriverPageClient({ driverId }: DriverPageClientProps) {
         setLoading(true)
         setError(null)
 
-        const response = await fetch(withBasePath(`/foomatic-db/drivers/${driverId}.json`))
+        const response = await fetch(withBasePath(`/foomatic-db/drivers/${encodeURIComponent(driverId)}.json`))
         if (!response.ok) {
           throw new Error("This driver entry could not be loaded.")
         }
@@ -339,7 +340,7 @@ export default function DriverPageClient({ driverId }: DriverPageClientProps) {
                 <h3 className="text-sm font-semibold uppercase tracking-[0.18em] text-muted-foreground">Description</h3>
                 <div
                   className="prose prose-sm mt-4 max-w-none text-foreground dark:prose-invert"
-                  dangerouslySetInnerHTML={{ __html: driver.comments }}
+                  dangerouslySetInnerHTML={{ __html: sanitizeFoomaticHtml(driver.comments) }}
                 />
               </FoomaticCard>
             ) : driver.shortDescription ? (

components/foomatic/PpdViewerClient.tsx

@@ -14,6 +14,7 @@ import { Button } from "@/components/ui/button"
 import { withBasePath } from "@/lib/foomatic/base-path"
 import { ppdFilePath } from "@/lib/foomatic/routes"
 
+// Restrict to known PPD output dirs and reject ".." to prevent path traversal.
 function isValidPpdPath(path: string | null) {
   return Boolean(path && (path.startsWith("/ppd/") || path.startsWith("/ppds/")) && !path.includes(".."))
 }

components/foomatic/PrinterPageClient.tsx

@@ -21,28 +21,53 @@ import {
 import { Button } from "@/components/ui/button"
 import { withBasePath } from "@/lib/foomatic/base-path"
 import { driverHref, ppdViewHref } from "@/lib/foomatic/routes"
+import { sanitizeFoomaticHtml } from "@/lib/foomatic/sanitize"
 import type { Printer } from "@/lib/foomatic/types"
 import { calculateAccurateStatus } from "@/lib/foomatic/utils"
+import RecommendedPrintersSection, {
+  SimilarPrintersTeaser,
+} from "@/components/foomatic/RecommendedPrintersSection"
 
 interface PrinterPageClientProps {
   printerId: string
 }
 
 function LoadingState() {
   return (
-    <div className="grid gap-6 lg:grid-cols-[minmax(0,0.9fr)_minmax(0,1.5fr)]" role="status" aria-label="Loading printer details">
-      <FoomaticCard className="space-y-4 p-6">
-        <div className="h-8 w-36 animate-pulse rounded bg-muted" />
-        <div className="h-5 w-28 animate-pulse rounded bg-muted" />
-        <div className="h-20 animate-pulse rounded-xl bg-muted" />
-      </FoomaticCard>
-
-      <div className="space-y-6">
-        {Array.from({ length: 2 }).map((_, index) => (
-          <FoomaticCard key={index} className="space-y-4 p-6">
-            <div className="h-7 w-40 animate-pulse rounded bg-muted" />
-            <div className="h-4 w-56 animate-pulse rounded bg-muted" />
-            <div className="h-20 animate-pulse rounded-xl bg-muted" />
+    <div className="space-y-6" role="status" aria-label="Loading printer details">
+      <div className="grid gap-6 lg:grid-cols-[minmax(0,0.9fr)_minmax(0,1.5fr)]">
+        <FoomaticCard className="space-y-4 p-6">
+          <div className="h-8 w-36 animate-pulse rounded bg-muted" />
+          <div className="h-5 w-28 animate-pulse rounded bg-muted" />
+          <div className="h-20 animate-pulse rounded-xl bg-muted" />
+        </FoomaticCard>
+
+        <div className="space-y-6">
+          {Array.from({ length: 2 }).map((_, index) => (
+            <FoomaticCard key={index} className="space-y-4 p-6">
+              <div className="h-7 w-40 animate-pulse rounded bg-muted" />
+              <div className="h-4 w-56 animate-pulse rounded bg-muted" />
+              <div className="h-20 animate-pulse rounded-xl bg-muted" />
+            </FoomaticCard>
+          ))}
+        </div>
+      </div>
+
+      <div className="space-y-4">
+        <div className="h-7 w-44 animate-pulse rounded bg-muted" />
+        {Array.from({ length: 3 }).map((_, index) => (
+          <FoomaticCard key={index} className="p-6">
+            <div className="flex flex-col gap-4 lg:flex-row lg:items-start lg:justify-between">
+              <div className="flex-1 space-y-3">
+                <div className="h-3.5 w-24 animate-pulse rounded bg-muted" />
+                <div className="h-5 w-48 animate-pulse rounded bg-muted" />
+                <div className="flex gap-2">
+                  <div className="h-6 w-20 animate-pulse rounded-full bg-muted" />
+                  <div className="h-6 w-16 animate-pulse rounded-full bg-muted" />
+                </div>
+              </div>
+              <div className="h-9 w-28 animate-pulse rounded-md bg-muted" />
+            </div>
           </FoomaticCard>
         ))}
       </div>
@@ -61,7 +86,7 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
         setLoading(true)
         setError(null)
 
-        const response = await fetch(withBasePath(`/foomatic-db/printers/${printerId}.json`))
+        const response = await fetch(withBasePath(`/foomatic-db/printers/${encodeURIComponent(printerId)}.json`))
         if (!response.ok) {
           throw new Error("This printer entry could not be loaded.")
         }
@@ -120,6 +145,12 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
   }
 
   const status = calculateAccurateStatus(printer)
+  const hasCapabilities =
+    (printer.color !== undefined && printer.color !== "unknown") ||
+    (printer.duplex !== undefined && printer.duplex !== "unknown") ||
+    printer.maxDpi != null ||
+    (printer.connectivity?.length ?? 0) > 0 ||
+    (printer.commandsets?.length ?? 0) > 0
   const drivers = [...(printer.drivers ?? [])].sort((left, right) => {
     if (left.id === printer.recommended_driver) return -1
     if (right.id === printer.recommended_driver) return 1
@@ -170,19 +201,23 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
                 </div>
               </div>
 
-              {printer.recommended_driver ? (
-                <FoomaticCard className="max-w-sm p-4">
-                  <p className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
-                    Recommended driver
-                  </p>
-                  <Link
-                    href={driverHref(printer.recommended_driver)}
-                    className="mt-2 inline-block text-sm font-medium text-primary hover:underline"
-                  >
-                    {printer.recommended_driver.replace(/^driver\//, "")}
-                  </Link>
-                </FoomaticCard>
-              ) : null}
+              <div className="flex w-full max-w-sm flex-col gap-4 md:w-auto">
+                {printer.recommended_driver ? (
+                  <FoomaticCard className="p-4">
+                    <p className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
+                      Recommended driver
+                    </p>
+                    <Link
+                      href={driverHref(printer.recommended_driver)}
+                      className="mt-2 inline-block text-sm font-medium text-primary hover:underline"
+                    >
+                      {printer.recommended_driver.replace(/^driver\//, "")}
+                    </Link>
+                  </FoomaticCard>
+                ) : null}
+
+                <SimilarPrintersTeaser printerId={printer.id} />
+              </div>
             </div>
           </div>
         </section>
@@ -225,64 +260,74 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
                     <FoomaticStatusBadge status={status} />
                   </dd>
                 </div>
-                {printer.color !== undefined && printer.color !== "unknown" ? (
-                  <div>
-                    <dt className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
-                      Color
-                    </dt>
-                    <dd className="mt-2 text-sm text-foreground">
-                      {printer.color ? "Color output" : "Monochrome only"}
-                    </dd>
-                  </div>
-                ) : null}
-                {printer.duplex !== undefined && printer.duplex !== "unknown" ? (
-                  <div>
-                    <dt className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
-                      Duplex
-                    </dt>
-                    <dd className="mt-2 text-sm text-foreground">
-                      {printer.duplex ? "Supported" : "Not supported"}
-                    </dd>
-                  </div>
-                ) : null}
-                {printer.connectivity && printer.connectivity.length > 0 ? (
-                  <div>
-                    <dt className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
-                      Connectivity
-                    </dt>
-                    <dd className="mt-2 flex flex-wrap gap-2">
-                      {printer.connectivity.map((item) => (
-                        <FoomaticBadge key={item} className="border-border bg-accent/50 text-muted-foreground">
-                          {item}
-                        </FoomaticBadge>
-                      ))}
-                    </dd>
-                  </div>
-                ) : null}
-                {printer.commandsets && printer.commandsets.length > 0 ? (
-                  <div>
-                    <dt className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
-                      Page description languages
-                    </dt>
-                    <dd className="mt-2 flex flex-wrap gap-2">
-                      {printer.commandsets.map((item) => (
-                        <FoomaticBadge key={item} className="border-border bg-accent/50 text-muted-foreground">
-                          {item}
-                        </FoomaticBadge>
-                      ))}
-                    </dd>
-                  </div>
-                ) : null}
               </dl>
 
+              {hasCapabilities ? (
+                <div className="mt-6 border-t border-border pt-5">
+                  <h3 className="text-xs font-semibold uppercase tracking-[0.18em] text-muted-foreground">
+                    Capabilities
+                  </h3>
+                  <dl className="mt-4 space-y-4">
+                    {printer.color !== undefined && printer.color !== "unknown" ? (
+                      <div>
+                        <dt className="text-xs font-medium text-muted-foreground">Color</dt>
+                        <dd className="mt-1 text-sm text-foreground">
+                          {printer.color ? "Color output" : "Monochrome only"}
+                        </dd>
+                      </div>
+                    ) : null}
+                    {printer.duplex !== undefined && printer.duplex !== "unknown" ? (
+                      <div>
+                        <dt className="text-xs font-medium text-muted-foreground">Duplex</dt>
+                        <dd className="mt-1 text-sm text-foreground">
+                          {printer.duplex ? "Supported" : "Not supported"}
+                        </dd>
+                      </div>
+                    ) : null}
+                    {printer.maxDpi != null ? (
+                      <div>
+                        <dt className="text-xs font-medium text-muted-foreground">Max resolution</dt>
+                        <dd className="mt-1 text-sm text-foreground">{printer.maxDpi} dpi</dd>
+                      </div>
+                    ) : null}
+                    {printer.connectivity && printer.connectivity.length > 0 ? (
+                      <div>
+                        <dt className="text-xs font-medium text-muted-foreground">Connectivity</dt>
+                        <dd className="mt-1 flex flex-wrap gap-2">
+                          {printer.connectivity.map((item) => (
+                            <FoomaticBadge key={item} className="border-border bg-accent/50 text-muted-foreground">
+                              {item}
+                            </FoomaticBadge>
+                          ))}
+                        </dd>
+                      </div>
+                    ) : null}
+                    {printer.commandsets && printer.commandsets.length > 0 ? (
+                      <div>
+                        <dt className="text-xs font-medium text-muted-foreground">
+                          Page description languages
+                        </dt>
+                        <dd className="mt-1 flex flex-wrap gap-2">
+                          {printer.commandsets.map((item) => (
+                            <FoomaticBadge key={item} className="border-border bg-accent/50 text-muted-foreground">
+                              {item}
+                            </FoomaticBadge>
+                          ))}
+                        </dd>
+                      </div>
+                    ) : null}
+                  </dl>
+                </div>
+              ) : null}
+
               {printer.notes ? (
                 <div className="mt-8 border-t border-border pt-6">
                   <h3 className="text-sm font-semibold uppercase tracking-[0.18em] text-muted-foreground">
                     Notes
                   </h3>
                   <div
                     className="prose prose-sm mt-4 max-w-none text-foreground dark:prose-invert"
-                    dangerouslySetInnerHTML={{ __html: printer.notes }}
+                    dangerouslySetInnerHTML={{ __html: sanitizeFoomaticHtml(printer.notes) }}
                   />
                 </div>
               ) : null}
@@ -382,7 +427,9 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
                 <div
                   className="prose prose-sm mt-5 max-w-none text-foreground dark:prose-invert"
                   dangerouslySetInnerHTML={{
-                    __html: driver.comments || "No additional notes are available for this driver.",
+                    __html: sanitizeFoomaticHtml(
+                      driver.comments || "No additional notes are available for this driver."
+                    ),
                   }}
                 />
 
@@ -410,6 +457,7 @@ export default function PrinterPageClient({ printerId }: PrinterPageClientProps)
             ))}
           </section>
         </div>
+        <RecommendedPrintersSection printerId={printer.id} />
       </FoomaticPageSection>
     </main>
   )