fix: Resolve LightGBM eval_set deprecation and NumPy/joblib compatibility issues - #1063
Merged
MvLieshout merged 6 commits intoAug 19, 2026
Conversation
MvLieshout
changed the base branch from
dependabot/uv/python-versions-4869eb52b8
to
main
August 17, 2026 11:40
MvLieshout
changed the base branch from
main
to
dependabot/uv/python-versions-4869eb52b8
August 17, 2026 11:40
MvLieshout
force-pushed
the
fix/deprecation-warnings-lightgbm-numpy
branch
2 times, most recently
from
August 17, 2026 12:16
2b4b4d8 to
bde46de
Compare
dependabot
Bot
force-pushed
the
dependabot/uv/python-versions-4869eb52b8
branch
from
August 19, 2026 04:40
43d88d2 to
f3607f8
Compare
…lity issues - Update MultiQuantileRegressor to use LightGBM 4.7+ new API with eval_X/eval_y parameters instead of deprecated eval_set - Use inspect.signature() with getattr() for type-safe API detection instead of string-based class name comparison - Maintain backward compatibility with XGBoost which still uses eval_set - Update holiday features test to match actual holiday library output (Pentecost instead of Whit Sunday) - Add doctest example that demonstrates LinearComponentSplitter instantiation - Add pytest filter for joblib/NumPy 2.5+ compatibility warning (upstream issue in joblib 1.5.3) - Cast numpy int values to int for mypy compatibility All tests pass: 1092 passed, 7 skipped Assisted-by: Claude (Anthropic) - LLM-assisted code generation Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
- Use getattr(model, 'fit') in MultiQuantileRegressor for type-safe API detection - Cast NumPy integers to int for mypy compatibility (cm.true_positives.sum() + cm.false_positives.sum()) Assisted-by: Claude (Anthropic) - LLM-assisted code generation Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
Move kwargs initialization inside the model loop to ensure each quantile model gets fresh kwargs dict. This prevents eval_set parameters from one model from polluting another model's fit call, which was causing XGBoost 'quantile alpha must be sorted' errors. Assisted-by: Claude (Anthropic) - LLM-assisted code generation Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
…zation - Sort quantiles in ascending order inline when passing to XGBoost's quantile_alpha parameter to prevent 'quantile alpha must be sorted' validation errors - Initialize kwargs outside model loop in MultiQuantileRegressor since all models of the same type receive identical eval parameters Assisted-by: Claude (Anthropic) - LLM-assisted code generation Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
Signed-off-by: Marnix van Lieshout <marnix.van.lieshout@alliander.com>
MvLieshout
force-pushed
the
fix/deprecation-warnings-lightgbm-numpy
branch
from
August 19, 2026 12:27
fde0755 to
2991b05
Compare
|
egordm
approved these changes
Aug 19, 2026
MvLieshout
merged commit Aug 19, 2026
d2b1657
into
dependabot/uv/python-versions-4869eb52b8
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes deprecation warnings from LightGBM 4.7+ and NumPy 2.5+ compatibility issues with joblib when running
uv run poe all.Type of change
Changes
Testing
AI disclosure
Assisted-by:trailer)