Conversation
- Add a note that the example/1c_2d_cluster directory was removed from the master branch of OpenTenBase/OpenTenBase (commit aca7e2c) and point readers to the opentenbase_ctl based Quick Start flow instead - Fix the pgxc.conf typo: the config file used by 'deploy all' is pgxc_ctl.conf, matching DEFAULT_CONF_FILE_NAME in contrib/pgxc_ctl/pgxc_ctl.h Fixes OpenTenBase/OpenTenBase#203 Signed-off-by: muzimu217 <1278844978@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复内容
Docker 部署指南(docs/guide/15-docker-deploy.md 与 15-docker-deploy.en.md)存在两处与当前主仓 master 分支不符的问题:
过期的 example/1c_2d_cluster 引用:
example/1c_2d_cluster示例目录已从 OpenTenBase/OpenTenBase master 分支移除(commitaca7e2c)。在两份指南的对应小节添加提示说明,指出该步骤仅适用于仍包含该目录的旧版本源码,并引导最新代码的用户参考 Quick Start 中基于opentenbase_ctl的部署流程。配置文件名笔误:
deploy all步骤注释中写的pgxc.conf实际应为pgxc_ctl.conf。依据:主仓contrib/pgxc_ctl/pgxc_ctl.h中DEFAULT_CONF_FILE_NAME定义为"pgxc_ctl.conf"。修改范围
2 个文件,+8/−2 行,中英文文档同步修改。
Fixes OpenTenBase/OpenTenBase#203