Fix GUI slot duplication and empty sell navigation - #304
Closed
Alexteens24 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slot_*sections when GUI layout files are migratedsell_and_exphas no items to sellRoot cause
The version-less YAML migrator treated missing slot paths as missing defaults. Moving or deleting a configured button therefore caused its original default slot to be restored on reload.
The empty
sell_and_exppath also called a legacy XP helper that always reopened the main GUI, including when there was no XP to collect.Impact
Server owners can move or remove GUI buttons without the updater duplicating them. Players using layouts such as DonutSMP_v2 remain in the current GUI when an empty sell action fails or only collects XP.
Validation
./gradlew buildgit diff --checkCloses #301