Skip to content

Update OrchardCoreContrib Submodule Version - #320

Open
hishamco wants to merge 1 commit into
mainfrom
update-submodule
Open

hishamco wants to merge 1 commit into
mainfrom
update-submodule

Conversation

@hishamco

Copy link
Copy Markdown
Member

Updated OrchardCoreContrib from 952f4f4 to e130aa4.

Details

This automated submodule update was generated by workflow.

View changes

@hishamco hishamco added dependencies Pull requests that update a dependency file submodule labels Aug 15, 2026
@hishamco

Copy link
Copy Markdown
Member Author

@copilot, fix the broken tests

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@copilot, fix the broken tests

Fixed in the latest commit. The root cause was a YesSql version conflict: the submodule bump added YesSql 6.0.0 which removed IStore.InitializeCollectionAsync(string) from the interface, but OrchardCore 3.0.1 was compiled against YesSql 5.4.7 and still calls that method at runtime — causing MissingMethodException in the HealthChecks tests.

The fix introduces a minimal OrchardCoreContrib.HealthChecks.Tests.Web project (Microsoft.NET.Sdk.Web) that references only OrchardCore.Application.Cms.Targets + OrchardCoreContrib.HealthChecks (no OrchardCoreContrib.Data.YesSql). This project is used as the assembly entry point for OrchardCore module name discovery in tests, replacing the previous reference to OrchardCoreContrib.Modules.Web which pulled in the YesSql 6.0.0 dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants