Conversation
…ove local time zone differences;
selway
force-pushed
the
feature-avaloniaui12
branch
from
July 22, 2026 08:32
e204172 to
274c044
Compare
Author
|
Hi team, It seems like a NuGet package restore failure during the macOS runner step. Could you please share the detailed error logs for the dotnet restore step, or let me know if there are specific NuGet feeds / configurations required for CI? |
Contributor
|
Thank you, @selway ! |
helderjgoncalves
self-requested a review
July 31, 2026 13:54
danielmeza
added a commit
to danielmeza/kicad-ultra
that referenced
this pull request
Sep 22, 2026
Brings the branch up to master 8e4ed2e, KiCadSharp 0.4.0 and SExpressions 0.2.0 included. One textual conflict, and four places where master's code needed the Avalonia 12 port applied to it. Views/MainWindow.axaml.cs, the conflict. Master's download handler is kept whole: - refusing never calls Continue, and a refused id is cancelled on its next update (#97, #106); - only a download the handler accepted becomes an import, and only at the path it accepted; - the folder comes from IConfigService, and nothing reads Avalonia state on CEF's thread (#108, #111). This branch had its own answer to the last one, handing the handler the view model; master's replaces it. On top of master's handler go this branch's browser changes: CefGlue's AvaloniaCefBrowser used directly, the handlers set in the constructor instead of through WebViewControl's GlobalWebViewInitialized, WebviewUrl followed through NavigateTo, and SameBrowserPopupHandler. NavigateTo is also how Find on Ultra Librarian (#100) reaches the browser. CefGlue.Common is still 120.6099.211, where OnBeforeDownload returns void, so the override is unchanged. ReactiveUI.Avalonia 11.4.13 -> 12.0.3. The previous master merge kept 11.4.13, but the CefGlue.Avalonia built from OutSystems/CefGlue#249 depends on ReactiveUI.Avalonia >= 12.0.3, and restore failed with NU1605. That was the red CI build on the last push. 12.0.3 is still ReactiveUI 23.2.28, the ReactiveUI master has, so #116's search pipeline builds unchanged here. ReactiveUI 24 is the next commit. Settings (#96, #103, #115): the text boxes master added use Watermark, which Avalonia 12 makes obsolete; they use PlaceholderText, like the others. The #if DEBUG `using Avalonia;` that #90 added in AboutWindow and SettingsWindow goes with the AttachDevTools calls this branch had already removed. Avalonia 12's developer tools attach once, in App. Program.cs (#95, #104) is merged as master has it: HarfBuzzPreload, SetLogDirectory and the MCP logging allowlist are unchanged. Only the UseReactiveUI comment changes, because the CefGlue build no longer brings in the old Avalonia.ReactiveUI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHQsqcKVEiAKvCS98Hn4Yh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Unit Test
The existing unit test code is not compatible with my timezone.
Test with UTC
Related issue
#246
WebView #403