ROU-13031: Use default line-height on tags - #1256
Merged
Merged
Conversation
|
🖼️ Storybook: Chromatic UI tests result: ✅ Passed
|
OS-susmitabhowmik
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR is for keeping Tag at its min-height instead of growing from inherited body line-height.
What was happening
.tagusedline-height: var(--osui-font-line-height-full), and the default size rendered taller than the 20px min-height.What was done
line-height: normalon.tagso the line box follows the tag font-size instead of the body leading.min-height(20px default, 16px small, 28px medium).Test Steps
Screenshots
(prefer animated gif)
Checklist