Skip to content

ROU-13031: Use default line-height on tags - #1256

Merged
os-davidlourenco merged 1 commit into
ROU-12714from
ROU-13031
Sep 10, 2026
Merged

ROU-13031: Use default line-height on tags#1256
os-davidlourenco merged 1 commit into
ROU-12714from
ROU-13031

Conversation

@os-davidlourenco

@os-davidlourenco os-davidlourenco commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

This PR is for keeping Tag at its min-height instead of growing from inherited body line-height.

What was happening

  • .tag used line-height: var(--osui-font-line-height-full), and the default size rendered taller than the 20px min-height.

What was done

  • Set line-height: normal on .tag so the line box follows the tag font-size instead of the body leading.
  • Height is then controlled by min-height (20px default, 16px small, 28px medium).

Test Steps

  1. Open sample app
  2. Check the default size (no size class): the tag should be 20px tall, not ~28px.
  3. Switch Size to small: the tag should be 16px tall.
  4. Switch Size to medium: the tag should be 28px tall.
  5. Confirm the label is still readable and vertically centered for each size, including IsLight and shape variants.

Screenshots

(prefer animated gif)

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@os-davidlourenco
os-davidlourenco requested a review from a team as a code owner September 10, 2026 11:00
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🖼️ Storybook: Chromatic UI tests result: ✅ Passed

Metric Value
Visual changes 1
Errors 0
Storybook Preview
Chromatic Build View Results

@os-davidlourenco os-davidlourenco added the bug Something isn't working label Sep 10, 2026
@os-davidlourenco
os-davidlourenco merged commit 54a3c03 into ROU-12714 Sep 10, 2026
15 of 16 checks passed
@os-davidlourenco
os-davidlourenco deleted the ROU-13031 branch September 10, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants