Clear post-merge OSV advisories (cxx, Go stdlib, cgmath)#349
Merged
Conversation
…, ignore the unfixed cgmath advisories
… dependency chains and owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge dependency hygiene: the OSV Scanner push-gate on
devwent red after #347 merged, from 5 newly-disclosed advisories in transitive deps (all Unknown severity, none introduced by #347).cxx1.0.194go/pecos/go.mod→go 1.26.5(fixed)cgmath0.18.0cgmath0.18.0swap_columns(a, a)UB; no fixed releasecgmath triage: both are INFO-level, transitive via
hugr-core → hugr → tket → pecos-hugr, and 0.18.0 is the latest release (no upstream fix). RUSTSEC-2026-0197 requires callingMatrix::swap_columnswith identical indices, which only hugr/tket internals could do — PECOS never calls it. Suppressed inosv-scanner.tomlwith the standard chain/owner/reason, to re-check on a hugr/tket bump.Verification:
cargo treeresolves (cxx 1.0.195, cgmath 0.18.0);pecos-chromobius(cxx consumer) builds clean;osv-scanner.tomlparses;go-version-consistencystructural checks unaffected andgo-testusesstable(≥ 1.26.5). CI OSV Scanner is authoritative.Notes from review: (1) The lockfile diff is surgically restricted to the four cxx-family hunks —
cargo updateunder cargo 1.97 also wants to re-normalize unrelated dependency edges (windows-sys/unicode-width/hashbrown/indexmap duplicates); that churn is benign but was excluded to keep this diff minimal, so expect it to reappear on the next fullcargo update. (2) Pre-existing, not changed here: govulncheck inside the OSV scanner image has been silently skippinggo/pecossince the go.mod directive passed 1.26.4 (image ships Go 1.26.2,GOTOOLCHAIN=local); lockfile-level stdlib matching still catches Go advisories, but code-level reachability analysis is absent until the scanner image ships a newer Go.