Smoke-test wheels against their real dependency metadata#354
Merged
Conversation
… of a hand-pinned list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the Codex cross-review of the post-release maintenance plan: both wheel smoke lanes (
pr_smoke_testinpython-release.yml,python-compat-smokeinpython-test.yml) hand-install a stale dependency set (guppylang>=0.21.6,tket<0.12.16,hugr>=0.13.0) and then install the quantum-pecos wheel with--no-deps. The package metadata has moved on (tket>=0.13,<0.14,guppylang>=0.21.16,<0.22,hugr>=0.16,<0.17), so the smoke test could pass in an environment that violates the wheel's ownRequires-Dist— green smoke, unresolvable metadata.Fix: install all local wheels in a single resolver invocation — the local
pecos-rslib/pecos-rslib-llvmwheels satisfy quantum-pecos's exact pins (which don't exist on PyPI for unreleased versions), and every other dependency resolves from the wheel's real metadata. Thenuv pip checkvalidates the resulting environment. No duplicated pin list left to drift.The lanes run on this PR, so the fix proves itself in CI here.