test(cholesky): align with Paddle compat cholesky behavior#69
Open
youge325 wants to merge 1 commit into
Open
Conversation
新增 CholeskyTest 跨框架对比测试，覆盖: - Shape: 2x2, 3x3, 8x8, batch 2x3x3 - Dtype: kFloat, kDouble - API 变体: at::cholesky, Tensor::cholesky, upper=true/false - 异常: 非正定矩阵 更新 tensor_body.md 中 cholesky 状态为已对齐。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds cross-framework coverage for the ATen cholesky API and updates the compatibility status documentation to reflect that both free-function and tensor-method variants are aligned.
Changes:
- Adds
CholeskyTestcovering 2D/batched inputs, float/double dtypes,uppervariants, tensor method calls, and non-positive-definite error behavior. - Updates the ATen tensor API status table to mark
choleskyas implemented/aligned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/ATen/ops/CholeskyTest.cpp |
Adds result-comparison tests for at::cholesky and Tensor::cholesky. |
doc/ATen/core/tensor_body.md |
Marks cholesky support as complete for both Tensor and ATen APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
新增 CholeskyTest 跨框架对比测试，对齐 Paddle compat 层 cholesky 接口行为。
Changes
Test Coverage
Verification
Related: PaddlePaddle/Paddle#79194
🤖 Generated with Claude Code