Avoid actioning participation stop events for leavers#39
Merged
Conversation
Signed-off-by: Pugzy <pugzy@mail.com>
Pablete1234
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a player is leaving the server (from a team to no team) then the plugin currently tries to cancel that.
This isn't really possible, the option only exists as a team switch calls the same method (with actual teams).
The event getting "cancelled" can break things upstream in PGM where it no longer reacts to the event.
One example of this is the activity tracker which stores data about when a player left, this is listened for in PGM following the
PlayerParticipationStopEvent, if this is cancelled then no data is stored for a leaving player.