Report the size and location of a resource-constraint failure in TPI - #1213
Open
arihantlodha-cmd wants to merge 2 commits into
Open
Report the size and location of a resource-constraint failure in TPI#1213arihantlodha-cmd wants to merge 2 commits into
arihantlodha-cmd wants to merge 2 commits into
Conversation
When the transition path fails the resource-constraint check, the error was a bare 'equilibrium not found (RC_error)' with no indication of how large the violation was or where it occurred, so diagnosing it meant reloading the saved path and profiling resource_constraint_error by hand. This puts the maximum absolute error, the period it occurs in, and the tolerance in the message, and notes how to read it: a violation confined to the first or last periods is usually an initial- or terminal-boundary artifact, while one spread across the path points to an inconsistent calibration. Also fixes the 'equlibrium' typo in that message.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 74.07% 74.09% +0.02%
==========================================
Files 22 22
Lines 5920 5925 +5
==========================================
+ Hits 4385 4390 +5
Misses 1535 1535
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Codecov flagged the new resource-constraint diagnostic lines as uncovered. Pull the message construction out of run_TPI into a small _rc_error_message helper and add test_rc_error_message, which checks it names the largest violation, the period it occurs in, and the tolerance. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a transition path fails the resource-constraint check, the error is a bare
Transition path equlibrium not found (RC_error)with no indication of how large the violation is or which period it is in. Working out whether a failure is a benign boundary artifact or a real calibration problem meant reloading the savedTPI_vars.pkland profilingresource_constraint_errorby hand.This puts the diagnostic in the message: the maximum absolute resource-constraint error, the period it occurs in, and the tolerance, plus a one-line note on how to read it (a violation confined to the first or last periods is usually an initial- or terminal-boundary artifact; one spread across the path points to an inconsistent calibration). It mirrors the existing outer-loop stall messages, which already name the likely cause. Also fixes the
equlibriumtypo in that message.Message-only change: it does not alter when the check fires, only what it reports when it does.