Lift the ogcore<0.18 cap: floor at 0.18.1 - #70
Open
MaxGhenis wants to merge 3 commits into
Open
Conversation
The cap in PSLmodels#69 guarded against ogcore 0.18.0, whose get_pop_objs asserted income_percentiles before its homogeneous-case branch. That was fixed upstream in 0.18.1 (PSLmodels/OG-Core#1182), so the cap is now stale; floor at 0.18.1 so the fix is guaranteed and newer OG-Core (0.19.x) is admitted.
jdebacker
self-requested a review
August 24, 2026 13:33
jdebacker
approved these changes
Aug 24, 2026
Updated required Python version to 3.12 and adjusted supported Python versions.
jdebacker
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69. The
ogcore>=0.15.6,<0.18cap guarded against ogcore 0.18.0, whoseget_pop_objsassertedincome_percentilesbefore its homogeneous-case branch (PSLmodels/OG-Core#1180). That was fixed upstream in 0.18.1 (PSLmodels/OG-Core#1182, merged and released 7/24), so the cap is stale. This floors atogcore>=0.18.1— the fix is guaranteed and current OG-Core (0.19.x) is admitted.One-line dependency change; the calibrate tests added in #69 exercise
get_pop_objson the homogeneous path.🤖 Generated with Claude Code