feat: add API key notification rotatable field from api-specifications#2389 - #230
Open
cursor[bot] wants to merge 1 commit into
Open
feat: add API key notification rotatable field from api-specifications#2389#230cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Jed Patterson <jed.patterson@paddle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the nullable
rotatablefield to the shared API-key webhook payload and runtime entity for all five released API-key notification events.Source: api-specifications#2389
Linear: DX-1011
Spec-to-SDK mapping
ApiKeyPayload.rotatable: boolean | nullto the public webhook responsesrc/notifications/types/api-key/api-key-notification-response.tsrotatableon the runtime notification entitysrc/notifications/entities/api-key/api-key-notification.tsrotatable: truesrc/__tests__/mocks/notifications/api-key-created.mock.ts,api-key-updated.mock.ts,api-key-expiring.mock.tsrotatable: falsesrc/__tests__/mocks/notifications/api-key-expired.mock.ts,api-key-revoked.mock.tsCHANGELOG.md,package.json(3.9.0)Intentionally excluded
apps/paddle-events/**contracts are excluded because they are marked@internalUseOnly.api_key.exposure_createduses a separate payload and is unaffected./eventsresource has untypeddata, so no resource model changes are needed.exposed_atdrift is outside api-specifications#2389 and remains unchanged.Validation
pnpm install --frozen-lockfile— passedpnpm build— passedpnpm typecheck:tests— passedpnpm test --runInBand— 34 suites, 275 tests passedpnpm test --runInBand src/__tests__/notifications/notifications-parser.test.ts— 1 suite, 57 tests passed, including all five API-key eventspnpm prettier— passedpnpm lint— passed after fixing the documented, git-ignored generatedsrc/version.tsfinal newline locallyCreated by an automated spec-sync agent.