fix: add circuit breaker for oracle external API calls - #428
Merged
nonsobethel0-dev merged 1 commit intoAug 26, 2026
Merged
Conversation
Wrap Open-Meteo and AviationStack axios calls with a circuit breaker pattern to prevent resource waste from repeated failures. After a configurable threshold of consecutive failures the circuit opens and calls fail fast without hitting the network. A half-open state allows a single probe request after the reset timeout to test recovery. - Open-Meteo: 5 failures / 30s reset - AviationStack: 3 failures / 60s reset
|
@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap Open-Meteo and AviationStack axios calls with a circuit breaker pattern to prevent resource waste from repeated failures. After a configurable threshold of consecutive failures the circuit opens and calls fail fast without hitting the network. A half-open state allows a single probe request after the reset timeout to test recovery.
About this PR
This PR resolves 4 enhancement issues:
Closes #384
Closes #385
Closes #386
Closes #387
Circuit breaker pattern added to
src/oracle/oracle.service.ts:CircuitBreakerclass (lines 25–90) — three states: CLOSED (normal), OPEN (fail fast), HALF_OPEN (probe). Tracks consecutive failures and auto-transitions after a reset timeout.openMeteoBreaker— 5 failures, 30s reset (shared by rainfall + temperature calls)aviationStackBreaker— 3 failures, 60s reset (stricter since it's a paid API)fetchRainfallReading,fetchTemperatureReading,fetchFlightDelayReadingWhen the circuit is open, calls throw
ServiceUnavailableExceptionimmediately without network I/O. After the timeout, one probe request goes through — success closes the circuit, failure reopens it.Changes
#375 - API versioning strategy
X-API-Versionresponse headerDeprecationheader for v1 withLinkheader pointing to v2 successorx-api-versionheader for API version negotiation#373 - Pagination on policy and claims list endpoints
pageandlimitquery parameters toGET /api/v1/productsendpointgetActiveProductsservice method to support Prisma-based pagination withtake/skipgetClaimsByWalletQuery,getClaimHistory) already had pagination#372 - Rate limiting on claim submission endpoint
limit: 5/60s) toPOST /api/v1/claimsendpoint@Throttledecorator with stricter limits than global throttler (60/60s)#374 - Webhook support for policy/claim status changes
WebhooksServicewith register/unregister/list and status notification methodsWebhooksControllerwithPOST /api/v1/webhooks/registerandGET /api/v1/webhooksendpointspolicy.status.changeeventclaim.status.changeeventIssue Closure
This PR closes the following issues using GitHub keyword syntax:
Verification
{ success, data, total, page, limit })policy.status.change,claim.status.change)