docs: add SSE and webhook event documentation to Swagger - #431
Merged
nonsobethel0-dev merged 1 commit intoAug 26, 2026
Merged
Conversation
Add comprehensive OpenAPI documentation for the real-time event systems: - Create PolicyStatusEventDto for SSE event payload schema - Create webhook DTOs (RegisterWebhookDto, WebhookRegistrationResponseDto, WebhookListItemDto, PolicyStatusChangePayloadDto, ClaimStatusChangePayloadDto) with validation decorators and Swagger metadata - Document SSE endpoint with event data schema, status transition table, and EventSource connection example - Document webhook registration with event type table, payload schemas, and HMAC-SHA256 signature verification instructions - Add 'webhooks' and 'events' tags to Swagger config in DocumentBuilder
|
@Mainnet-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive OpenAPI documentation for the real-time event systems:
About this PR
Closes #405
Closes #406
Closes #407
Closes #408
What changed (5 files, +166/-9):
src/common/events/dto/sse-event.dto.ts(new) —PolicyStatusEventDtodocumenting the SSE event payload (policyId,status,timestamp) with status enum values.src/common/webhooks/dto/webhook.dto.ts(new) — Full set of webhook DTOs:RegisterWebhookDtowithclass-validatordecoratorsWebhookRegistrationResponseDto,WebhookListItemDtoPolicyStatusChangePayloadDto,ClaimStatusChangePayloadDtofor delivery payloadsWebhookEventTypeenum (policy.status.change,claim.status.change)src/policy/policy.controller.ts— SSE endpoint now has a detailed description with status transition table, event data schema, and anEventSourceconnection example. Response schema referencesPolicyStatusEventDto.src/common/webhooks/webhooks.controller.ts— Registration endpoint documents the event type table with payload shapes, HMAC-SHA256 signature verification instructions, and uses typed DTOs instead of inlineany. List endpoint response schema referencesWebhookListItemDto.src/main.ts— Addedwebhooksandeventstags to the SwaggerDocumentBuilder.This PR resolves 4 enhancement issues:
Changes
#375 - API versioning strategy
X-API-Versionresponse headerDeprecationheader for v1 withLinkheader pointing to v2 successorx-api-versionheader for API version negotiation#373 - Pagination on policy and claims list endpoints
pageandlimitquery parameters toGET /api/v1/productsendpointgetActiveProductsservice method to support Prisma-based pagination withtake/skipgetClaimsByWalletQuery,getClaimHistory) already had pagination#372 - Rate limiting on claim submission endpoint
limit: 5/60s) toPOST /api/v1/claimsendpoint@Throttledecorator with stricter limits than global throttler (60/60s)#374 - Webhook support for policy/claim status changes
WebhooksServicewith register/unregister/list and status notification methodsWebhooksControllerwithPOST /api/v1/webhooks/registerandGET /api/v1/webhooksendpointspolicy.status.changeeventclaim.status.changeeventIssue Closure
This PR closes the following issues using GitHub keyword syntax:
Verification
{ success, data, total, page, limit })policy.status.change,claim.status.change)