chore: bump Node to 24.20.0, enforce engines via pnpm, drop stale .npmrc - #1088
Merged
Conversation
- .nvmrc 24.2.0 -> 24.20.0 (latest 24.x; pre-satisfies upcoming dep engines floors like postcss-discard-duplicates v9) - pnpm-workspace.yaml: engineStrict: true. Verified enforced on pnpm 11.1.3 (CI) and 12.3.1; all 833 lockfile packages compatible with Node 24.20.0 and 26.8.1 - delete .npmrc: all three settings were verified no-ops on pnpm 11/12. engine-strict was silently ignored (hence the workspace setting), resolution-mode=highest is the default, and --experimental-global-webcrypto was removed from Node (global webcrypto is standard since Node 19) - .anthony.CLAUDE.md: update Node reference Validated on Node 24.20.0 / pnpm 11.1.3: check 0 errors, tests 51/51, lint 0 errors (baseline warnings unchanged)
✅ Deploy Preview for pauseai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While analyzing which dependency-dashboard updates would break the project, I found that engines enforcement was silently off everywhere — and
.npmrc'sengine-strict=truewas a no-op on modern pnpm. This PR turns engines into a real guard, aligned with what the dependency tree actually requires.Changes
.nvmrc:24.2.0→24.20.0(latest 24.x line; also pre-satisfies upcoming dependency engines floors such aspostcss-discard-duplicatesv9's^24.15.0andnpm-run-all2's^24.15.0)pnpm-workspace.yaml: addengineStrict: true— this is the mechanism that actually enforcesengineson pnpm 11/12 (.npmrc'sengine-strictis silently ignored there).npmrc: deleted — all three settings were verified no-ops:engine-strict=true: silently ignored by pnpm 11.1.3 (CI) and 12.3.1; a dependency with incompatibleenginesinstalled cleanly with it setresolution-mode=highest: already pnpm's default (verified with a fresh add resolving latest)node-options=--experimental-global-webcrypto: doubly dead — the flag was removed from Node entirely (globalcrypto.subtleis standard since Node 19); v24.20.0 CLI docs contain no trace of it.anthony.CLAUDE.md: Node reference updated to match.nvmrcEvidence
engineStrict: trueverified as hard-failing (ERR_PNPM_UNSUPPORTED_ENGINE) on both pnpm 11.1.3 and 12.3.1 with a synthetic violating depengines.pnpmpin that isn't enforced even underengineStrict, and an optional-only platform binary pnpm skips).npmrcengine-strict did nothing there eitherValidation (Node 24.20.0 / pnpm 11.1.3 — CI-equivalent)
pnpm install✅ (now actually validating engines)pnpm check✅ 0 errors / 12 pre-existing warningspnpm test --run✅ 51/51pnpm lint✅ 0 errors / 2 pre-existing warnings