Fail closed when TES NSFW, takedown, nullcast, or media reads error - #24
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Interstitial on a quote/RT/ancestor is keep-and-warn, not Drop. The leak next to that is TES nsfw/takedown/nullcast/media RPC failure treated as "flag unset", so those rules never fire and the post serves clean. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#134. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
Pitchfork-and-Torch
deleted the
cursor/vf-tes-safety-flag-fail-closed-80ac
branch
September 18, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 2 check
Quote / RT / ancestor
Action::Interstitialdoes not setdrop_ancillary_posts. Verified.should_drop_reasononly matchesAction::Drop.AncillaryVFFilterreads that flag. Home NSFW rules emit Interstitial; Recs has Drop twins. Interstitial means keep-and-warn, not hard-drop. Not rewritten.Bug
TES tweet-flag RPCs already distinguish Found / NotFound / Failed.
build_tweet_featuresthen doesget(...).unwrap_or(false). Failed and NotFound both become “flag unset”. NSFW, takedown, nullcast, and DMCA/geo rules never fire.Genuine
NotFound/Ok(None)(no flag) is unchanged.Fix
If nsfw_user / nsfw_admin / has_takedown / nullcast / media is Failed for a tweet id, drop that candidate.
FilterTweetsmaps the miss toVerdict::unresolved_author.Tests
Found / NotFound / empty stay; Failed nsfw/takedown/nullcast/media drop. Standalone harness: 12 assertions passed.
cargo testcannot run. Public dump has no VF / Home Mixer manifest.Upstream
Preferred PR (cut from xai-org/main, uses
takedown_reasonsinstead ofhas_takedown): xai-org#134This fork-main branch has extra TES fields. Do not send this diff to xai-org.
Leftover
Gizmoduck author NSFW miss is upstream xai-org#125. Socialgraph relationship miss still fail-opens.