Drop quotes, retweets, and replies whose ancillary VF verdict is Interstitial - #30
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Home NSFW rules emit Interstitial (keep-and-warn). should_drop_reason only matched Action::Drop, so a quote/RT/ancestor Interstitial left drop_ancillary_posts unset. The wrapper stays Allow and visibility_reason never carries the child warn, so NSFW/gore embeds as a normal card. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
xai-org#134 leftover. Quote / RT / ancestor
Action::Interstitialdoes not setdrop_ancillary_posts. Verified onxai-org/main(902a06f).should_drop_reasononly matchedAction::Drop. Home NSFW / gore / card / nsfw-author rules emit Interstitial. Recs has Drop twins, but RT sources are fetched atTimelineHome, and a dual-role id is overwritten by the Home Interstitial.AncillaryVFFilterreads the flag. The wrappervisibility_reasonis the primary Allow. Mixer serializes only that. This repo does not draw an interstitial.This is not xai-org#115 (Following quotes at Home vs Recs). Not xai-org#119 (RT primary looked up by wrapper id). Not xai-org#121 (VF
Err/ missing key). xai-org#121 leftover text called this Interstitial≠Drop path out. xai-org#134 left it as keep-and-warn. Keep-and-warn is only real on the primary card.Five-line proof
VFCandidateHydrator::should_drop_reason(quote / RT / ancestor lookups inshould_drop_ancillary)AncillaryVFFilter(drop_ancillary_posts);candidates_to_scored_postswrites only primaryvisibility_reasonAction::Interstitialon a child did not set the flag; wrapper stayed AllowTimelineHomeRecommendations. Primary Interstitial still keep-and-warn viaVFFilter/visibility_reasonChange
Treat
Action::InterstitiallikeAction::Dropfor ancillary children only. Primary Interstitial is unchanged.Tests
drop_ancillary_postsStandalone decision-table harness (same match arms): 9/9 passed.
cargo testcannot run. Public dump has no Home Mixer manifest.Fork PR: none