Fail closed when gizmoduck user-label lookup is Err or missing - #31
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
GizmoduckAuthorHydrator kept Failed/omitted reads in the batch, then assemble used get_or_default so SpamHighRecall and LowQuality looked absent. Omit those ids before assemble. Confirmed NotFound stays unlabeled. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GizmoduckAuthorHydratorkeeps Failed and omitted gizmoduck reads asHydrated::Failed.CandidateFeatures::assemblethen callsget_or_default, which turns that into emptyAuthorFeatures/ emptyUserLabelSet.SpamHighRecallUserLabelRule(and sibling OON user-label drops) only check type presence. An empty set is Allow. A store error therefore lets a SpamHighRecall or LowQuality author keep ranking.Ok(None)/NotFoundis a confirmed unlabeled author. That path is unchanged.This is not xai-org#103 (allowlist store). This is not xai-org#125 (home-mixer origin-author NSFW/size). This is not xai-org#139 (tweet RTF / Manhattan safety-label hydrator). This is the VF gizmoduck consumer of user labels.
Five-line proof
GizmoduckAuthorHydrator/author_lookup_failed(get_or_defaultused to collapse Err/missing into empty labels)FilterTweetsomit-from-hydrate ->Verdict::unresolved_authorDropSpamHighRecallUserLabelRulenever firedfailed_ids. This is gizmoduck user labels.Change
Track Failed / missing gizmoduck author reads. Do not assemble them as default empty labels.
retain_candidates_with_usable_author_featuresomits those ids before assemble. ConfirmedNotFoundstays unlabeled and serves.Tests
NotFoundis not a failureStandalone decision-table harness (same match arms): 11 assertions passed.
cargo testcannot run. Public dump has no VF crate manifest.Fork PR: none