Stop seen/served filters from dropping replies to seen parents - #61
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
related_post_ids_iter treated in_reply_to_tweet_id as the same card as the reply. PreviouslySeen, PreviouslySeenBackup, and PreviouslyServed then hard-dropped followee replies whenever the parent was already in seen, impressed, or served ids. A reply is new speech. Keep same-card matching to the post itself and its retweet original only. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
related_post_ids_iterchainedin_reply_to_tweet_idnext to the candidate id and the retweet original. PreviouslySeen, PreviouslySeenBackup, and PreviouslyServed hard-drop a candidate when any related id is in seen / impressed / served.A reply is new speech. Seeing or serving the parent is not seeing the reply. Followee replies to a post the viewer already scrolled past never reach For You.
This is not xai-org#151 (quote same-card). xai-org#151 adds
quoted_tweet_id. This removes the parent id. A retweet of a seen original still drops.Five-line proof
in_reply_to_tweet_idon an in-network replyrelated_post_ids_iter)Fix
Same-card ids are the post and its retweet original only.
Tests
cargo testcannot run. Public dump has no Home Mixer manifest.Fork PR: none