Drop For You posts whose author handle matches a muted keyword - #64
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Gizmoduck already hydrates author_screen_name. ViewerMutedKeywordFilter only matched tweet_text, so @mutedkeyword posts with clean body text still served. Quote and RT original handles are separate classes. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Gizmoduck already writes
author_screen_nameon For You.ViewerMutedKeywordFilteronly matchedtweet_text.A muted keyword that is the card author's handle never hid the post when the body was clean.
@mutedkeywordposting"hello"still ranked.This is not quoted-author handle mute-keyword (xai-org#140). Not RT original-author handle mute-keyword (xai-org#164). Not Phoenix reply-parent VF (xai-org#180). Not notes x ranking (xai-org#171 / xai-org#177).
Fix
Tokenize the already-hydrated
author_screen_namewith the same mute-keyword matcher as tweet text.Proof
author_screen_namebefore ViewerMutedKeywordFiltertweet_textonly; card handle was never tokenizedTests